Declarative content scripts: Renderer-side: per-extension shared memory regions (lazily loaded)

extensions/renderer/user_script_set.h

Index: extensions/renderer/user_script_set.h
diff --git a/extensions/renderer/user_script_set.h b/extensions/renderer/user_script_set.h
index 48fc641298eb4ca99cfc4d4af6269e0d6661c72f..1448fb49f8e1fe53815bc0956e3db43f163c7102 100644
--- a/extensions/renderer/user_script_set.h
+++ b/extensions/renderer/user_script_set.h
@@ -33,6 +33,10 @@ class ScriptInjection;
 // inject on a page.
 class UserScriptSet : public content::RenderProcessObserver {

[Jeffrey Yasskin, 2014/07/24 21:09:19]

Stop inheriting from RenderProcessObserver if you don't implement any of its
methods anymore.

[Mark Dittmer, 2014/07/25 15:09:05]

Done.

  public:
+  // Provide UserScriptSetManager with accesss to OnUpdateUserScripts and
+  // scripts_.
+  friend class UserScriptSetManager;
+
   class Observer {
    public:
     virtual void OnUserScriptsUpdated(
@@ -60,11 +64,8 @@ class UserScriptSet : public content::RenderProcessObserver {
                      UserScript::RunLocation run_location);
 
  private:
-  // content::RenderProcessObserver implementation.
-  virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
-
   // Handle the UpdateUserScripts extension message.
-  void OnUpdateUserScripts(base::SharedMemoryHandle shared_memory,
+  bool OnUpdateUserScripts(base::SharedMemoryHandle shared_memory,

[Jeffrey Yasskin, 2014/07/24 21:09:19]

Any time you return a value, you should document what the value means. Yes,
Chrome is terrible at doing this, but that doesn't mean you should propagate the
problem.

[Mark Dittmer, 2014/07/25 15:09:05]

Done.

                            const std::set<std::string>& changed_extensions);
 
   // Update the parsed scripts from |shared memory|.