Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/renderer/user_script_set.cc

Issue 404613006: Declarative content scripts: Renderer-side: per-extension shared memory regions (lazily loaded) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add missing Disptacher::content_watcher_ initialization Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/user_script_set.cc
diff --git a/extensions/renderer/user_script_set.cc b/extensions/renderer/user_script_set.cc
index 5ab873955f026e98159d5567a4c111821d130c98..1ba38cb5e22b83c0c17139f6e7ab8fc151de7240 100644
--- a/extensions/renderer/user_script_set.cc
+++ b/extensions/renderer/user_script_set.cc
@@ -79,22 +79,12 @@ void UserScriptSet::GetInjections(
}
}
-bool UserScriptSet::OnControlMessageReceived(
- const IPC::Message& message) {
- bool handled = true;
- IPC_BEGIN_MESSAGE_MAP(UserScriptSet, message)
- IPC_MESSAGE_HANDLER(ExtensionMsg_UpdateUserScripts, OnUpdateUserScripts)
- IPC_MESSAGE_UNHANDLED(handled = false)
- IPC_END_MESSAGE_MAP()
- return handled;
-}
-
-void UserScriptSet::OnUpdateUserScripts(
+bool UserScriptSet::OnUpdateUserScripts(
base::SharedMemoryHandle shared_memory,
const std::set<std::string>& changed_extensions) {
if (!base::SharedMemory::IsHandleValid(shared_memory)) {
NOTREACHED() << "Bad scripts handle";
- return;
+ return false;
}
for (std::set<std::string>::const_iterator iter = changed_extensions.begin();
@@ -102,15 +92,18 @@ void UserScriptSet::OnUpdateUserScripts(
++iter) {
if (!Extension::IdIsValid(*iter)) {
NOTREACHED() << "Invalid extension id: " << *iter;
- return;
+ return false;
}
}
- if (UpdateScripts(shared_memory)) {
- FOR_EACH_OBSERVER(Observer,
- observers_,
- OnUserScriptsUpdated(changed_extensions, scripts_.get()));
+ if (!UpdateScripts(shared_memory)) {
+ return false;
}
+
+ FOR_EACH_OBSERVER(Observer,
+ observers_,
+ OnUserScriptsUpdated(changed_extensions, scripts_.get()));
+ return true;
}
bool UserScriptSet::UpdateScripts(

Powered by Google App Engine
This is Rietveld 408576698