Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 404613002: Fix BoringSSL build and tests on OS X. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix BoringSSL build and tests on OS X. - Fixes components build (otherwise multiple copies of boringssl get linked in). - Tweaks update_gypi_and_asm.py to sort tests. - Renegerates gypi and asm files to pick up a newline fix. Adds new tests to boringssl_unittest.cc. - Fix a size_t/int difference. BUG=393317

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -64 lines) Patch
M chrome/common/net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/boringssl.gyp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 chunk +45 lines, -34 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/aes/aes-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/aes/aesni-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/aes/vpaes-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/bn/bn-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/bn/co-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/bn/x86-mont.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/cpu-x86-asm.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/md5/md5-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/modes/ghash-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/rc4/rc4-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha1-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha256-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha512-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/aes/aes-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/aes/aesni-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/aes/vpaes-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/bn/bn-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/bn/co-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/bn/x86-mont.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/cpu-x86-asm.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/md5/md5-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/modes/ghash-x86.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/rc4/rc4-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha1-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha256-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha512-586.S View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
davidben
Sending this out for review now, though it should probably wait until Monday if the ...
6 years, 5 months ago (2014-07-18 19:49:35 UTC) #1
agl
LGTM. Note the android_{clang_}dbg failures. Hopefully that's just because of a different base revision.
6 years, 5 months ago (2014-07-18 20:25:37 UTC) #2
davidben
6 years, 5 months ago (2014-07-22 20:37:38 UTC) #3
On 2014/07/18 20:25:37, agl wrote:
> LGTM.
> 
> Note the android_{clang_}dbg failures. Hopefully that's just because of a
> different base revision.

Got landed as part of BoringSSL cutover.

Powered by Google App Engine
This is Rietveld 408576698