Athena's FocusRules

Athena's FocusRules
Introduce ContainerParams to control the container's behavior

Next Steps:
* Add explicit z-order priority and add check to catch violation.
* Refactor init process and add unit test


BUG=394121
TEST=This depends on the app_shell's initialization. I'll work on refactoring so that test/shell/main uses the same initialization process and add test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284031

[oshima, 2014-07-17 21:29:46]

jamescook -> apps/
sadrul -> athena

[oshima, 2014-07-17 21:31:05]

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
File athena/screen/public/screen_manager.h (right):

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:63: static wm::FocusRules*
CreateFocusRules();
I need to refactor initialization process to make virtual because the
ScreenManager is currently initialized after this call.

[James Cook, 2014-07-18 02:39:51]

LGTM with nits and one uninitialized member variable to fix

https://codereview.chromium.org/404563002/diff/80001/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/404563002/diff/80001/athena/main/athena_main....
athena/main/athena_main.cc:72:
DISALLOW_COPY_AND_ASSIGN(AthenaDesktopController);
nit: blank line above

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
File athena/screen/public/screen_manager.h (right):

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:31: struct ContainerParams {
I like how you use this params struct for initialization. It will be flexible
for future changes.

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:62: // TODO(osima): Make this virtual
function.
nit: osima -> oshima :-)

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:63: static wm::FocusRules*
CreateFocusRules();
On 2014/07/17 21:31:05, oshima wrote:
> I need to refactor initialization process to make virtual because the
> ScreenManager is currently initialized after this call.

Acknowledged.

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:186: : name(n) {
You need to initialize can_activate_children

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:209: // satatic
nit: static

[oshima, 2014-07-18 04:03:53]

https://codereview.chromium.org/404563002/diff/80001/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/404563002/diff/80001/athena/main/athena_main....
athena/main/athena_main.cc:72:
DISALLOW_COPY_AND_ASSIGN(AthenaDesktopController);
On 2014/07/18 02:39:51, James Cook wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
File athena/screen/public/screen_manager.h (right):

https://codereview.chromium.org/404563002/diff/80001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:62: // TODO(osima): Make this virtual
function.
On 2014/07/18 02:39:51, James Cook wrote:
> nit: osima -> oshima :-)

Done.

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:186: : name(n) {
On 2014/07/18 02:39:51, James Cook wrote:
> You need to initialize can_activate_children

Done. Thank you for catching this.

https://codereview.chromium.org/404563002/diff/80001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:209: // satatic
On 2014/07/18 02:39:51, James Cook wrote:
> nit: static

Done.

[sadrul, 2014-07-18 04:06:12]

LGTM

https://codereview.chromium.org/404563002/diff/100001/athena/screen/screen_ma...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/404563002/diff/100001/athena/screen/screen_ma...
athena/screen/screen_manager_impl.cc:36: virtual bool
SupportsChildActivation(aura::Window* window) const OVERRIDE {
// wm::BaseFocusRules:

[oshima, 2014-07-18 04:13:22]

https://codereview.chromium.org/404563002/diff/100001/athena/screen/screen_ma...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/404563002/diff/100001/athena/screen/screen_ma...
athena/screen/screen_manager_impl.cc:36: virtual bool
SupportsChildActivation(aura::Window* window) const OVERRIDE {
On 2014/07/18 04:06:12, sadrul wrote:
> // wm::BaseFocusRules:

Done.

[oshima, 2014-07-18 04:13:32]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-07-18 04:14:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/404563002/120001

[commit-bot: I haz the power, 2014-07-18 07:35:33]

Change committed as 284031