Athena's FocusRules

athena/screen/public/screen_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_SCREEN_PUBLIC_SCREEN_MANAGER_H_
 #define ATHENA_SCREEN_PUBLIC_SCREEN_MANAGER_H_
 
 #include <string>
 
 #include "athena/athena_export.h"
 
 namespace aura {
 class Window;
 }
 
 namespace gfx {
 class ImageSkia;
 }
 
+namespace wm {
+class FocusRules;
+}
+
 namespace athena {
 
 // Mananges basic UI components on the screen such as background, and provide
 // API for other UI components, such as window manager, home card, to
 // create and manage their windows on the screen.
 class ATHENA_EXPORT ScreenManager {
  public:
+  struct ContainerParams {

[James Cook, 2014/07/18 02:39:51]

I like how you use this params struct for initialization. It will be flexible
for future changes.

+    ContainerParams(const std::string& name);
+    std::string name;
+
+    // True if the container can activate its child window.
+    bool can_activate_children;
+  };
+
   // Creates, returns and deletes the singleton object of the ScreenManager
   // implementation.
   static ScreenManager* Create(aura::Window* root);
   static ScreenManager* Get();
   static void Shutdown();
 
   virtual ~ScreenManager() {}
 
   // Creates the container window that is used when creating a normal
   // widget without specific parent.
-  virtual aura::Window* CreateDefaultContainer(const std::string& name) = 0;
+  virtual aura::Window* CreateDefaultContainer(
+      const ContainerParams& params) = 0;
 
   // Creates the container window on the screen.
-  virtual aura::Window* CreateContainer(const std::string& name) = 0;
+  virtual aura::Window* CreateContainer(const ContainerParams& params) = 0;
 
   // Return the context object to be used for widget creation.
   virtual aura::Window* GetContext() = 0;
 
   // Sets the background image.
   virtual void SetBackgroundImage(const gfx::ImageSkia& image) = 0;
+
+  // Create a focus rules.
+  // TODO(osima): Make this virtual function.

[James Cook, 2014/07/18 02:39:51]

nit: osima -> oshima :-)

[oshima, 2014/07/18 04:03:52]

Done.

+  static wm::FocusRules* CreateFocusRules();

[oshima, 2014/07/17 21:31:05]

I need to refactor initialization process to make virtual because the
ScreenManager is currently initialized after this call.

[James Cook, 2014/07/18 02:39:51]

Acknowledged.

 };
 
 }  // namespace athena
 
 #endif  // ATHENA_SCREEN_PUBLIC_SCREEN_MANAGER_H_