Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: Tools/GardeningServer/ui/ct-builder-grid.html

Issue 404463003: Move commit list and builder latest revisions up to ct-unexpected-failures (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-builder-grid-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-builder-grid.html
diff --git a/Tools/GardeningServer/ui/ct-builder-grid.html b/Tools/GardeningServer/ui/ct-builder-grid.html
index 5956cc0b3bf3ac1b522a7787fe2296550f64d1b1..e4d332da0f8fd34778438a97f48da452768bee48 100644
--- a/Tools/GardeningServer/ui/ct-builder-grid.html
+++ b/Tools/GardeningServer/ui/ct-builder-grid.html
@@ -7,7 +7,7 @@ found in the LICENSE file.
<link rel="import" href="ct-builder.html">
<!-- Table of failure types, listing the failing builders for each type. -->
-<polymer-element name="ct-builder-grid" attributes="failures">
+<polymer-element name="ct-builder-grid" attributes="failures builderLatestRevisions">
<template>
<style>
table {
@@ -99,6 +99,7 @@ found in the LICENSE file.
<script>
Polymer({
failures: [],
+ builderLatestRevisions: {},
resultTypes: {},
keys: function(obj) {
@@ -123,15 +124,15 @@ found in the LICENSE file.
this.failures.forEach(function(failure) {
passingRevisions.push(failure.newestPassingRevision);
var results = failure.resultNodesByBuilder;
- Object.keys(results, (function(builderName) {
- var result = results[builderName];
+ Object.keys(results, (function(builder) {
+ var result = results[builder];
if (!result.is_unexpected)
return;
if (!Object.has(this.resultTypes, result.actual))
this.resultTypes[result.actual] = {};
- this.resultTypes[result.actual][builderName] =
- config.builders[builderName];
+ this.resultTypes[result.actual][builder] =
+ config.builders[builder];
}).bind(this));
}, this);
@@ -140,19 +141,27 @@ found in the LICENSE file.
this.resultTypes['BUILDING'] = buildingType;
},
+ _buildersInFlightForRevision: function(revision) {
+ return Object.keys(this.builderLatestRevisions).filter(function(builder) {
+ // FIXME: This should look at all chromium/v8/etc revisions as well.
+ // Is this concept of "building" builders even useful as is?
+ return parseInt(this.builderLatestRevisions[builder].blink, 10) < revision;
+ }.bind(this));
+ },
+
_getBuilding: function(revisions) {
var building = {};
- var builderNames = [];
+ var builders = [];
revisions.unique().forEach(function(revision) {
- builderNames.push.apply(builderNames,
- Object.keys(model.buildersInFlightForRevision(revision + 1)));
- });
- builderNames.unique().forEach(function(builderName) {
- if (!config.builders[builderName])
+ builders.push.apply(builders, this._buildersInFlightForRevision(revision + 1));
+ }.bind(this));
+
+ builders.unique().forEach(function(builder) {
+ if (!config.builders[builder])
return;
- building[builderName] =
- {'debug': config.builders[builderName].debug};
+ building[builder] = {'debug': config.builders[builder].debug};
});
+
return building;
},
});
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-builder-grid-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698