Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: Tools/GardeningServer/ui/ct-builder-grid-tests.html

Issue 404463003: Move commit list and builder latest revisions up to ct-unexpected-failures (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-builder-grid.html ('k') | Tools/GardeningServer/ui/ct-commit.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-builder-grid-tests.html
diff --git a/Tools/GardeningServer/ui/ct-builder-grid-tests.html b/Tools/GardeningServer/ui/ct-builder-grid-tests.html
index f6b26e1a8dcdd6adb6b72909c76a829821335ef6..4bb358e5ceb95fe1d00698fa19a1d9344c755259 100644
--- a/Tools/GardeningServer/ui/ct-builder-grid-tests.html
+++ b/Tools/GardeningServer/ui/ct-builder-grid-tests.html
@@ -56,46 +56,46 @@ var kExampleFailures = [{
"newestPassingRevision": 177165
}];
+var kExampleBuilderLatestRevisions = {
+ 'WebKit Mac10.7': {
+ blink: 177164,
+ },
+ 'WebKit Mac10.6 (dbg)': {
+ blink: 177166,
+ },
+ 'WebKit Win7 (dbg)': {
+ blink: 177166,
+ },
+};
+
module("ct-builder-grid");
asyncTest("basic", 11, function() {
- var oldBuildersInFlightForRevision = model.buildersInFlightForRevision;
- var reset = function() {
- model.buildersInFlightForRevision = oldBuildersInFlightForRevision;
- }
-
- try {
- model.buildersInFlightForRevision = function(revision) {
- return {'WebKit Mac10.7': {}};
- };
+ var grid = document.createElement('ct-builder-grid');
+ grid.failures = kExampleFailures;
+ grid.builderLatestRevisions = kExampleBuilderLatestRevisions;
- var grid = document.createElement('ct-builder-grid');
- grid.failures = kExampleFailures;
- requestAnimationFrame(function() {
- reset();
- var rows = grid.shadowRoot.querySelectorAll('tbody tr');
- equal(rows.length, 3);
+ requestAnimationFrame(function() {
+ var rows = grid.shadowRoot.querySelectorAll('tbody tr');
+ equal(rows.length, 3);
- var row1 = grid.shadowRoot.querySelector('tbody td.CRASH').parentNode;
- equal(row1.children.length, 3);
- equal(row1.children[1].querySelectorAll('ct-builder').length, 1);
- equal(row1.children[1].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.7');
+ var row1 = grid.shadowRoot.querySelector('tbody td.CRASH').parentNode;
+ equal(row1.children.length, 3);
+ equal(row1.children[1].querySelectorAll('ct-builder').length, 1);
+ equal(row1.children[1].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.7');
- equal(row1.children[2].querySelectorAll('ct-builder').length, 2);
- equal(row1.children[2].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.6 (dbg)');
- equal(row1.children[2].querySelectorAll('ct-builder')[1].builderName, 'WebKit Win7 (dbg)');
+ equal(row1.children[2].querySelectorAll('ct-builder').length, 2);
+ equal(row1.children[2].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.6 (dbg)');
+ equal(row1.children[2].querySelectorAll('ct-builder')[1].builderName, 'WebKit Win7 (dbg)');
- var row2 = grid.shadowRoot.querySelector('tbody td.TEXT').parentNode;
- equal(row2.children.length, 3);
- equal(row2.children[1].querySelectorAll('ct-builder').length, 1);
- equal(row2.children[2].querySelectorAll('ct-builder').length, 1);
+ var row2 = grid.shadowRoot.querySelector('tbody td.TEXT').parentNode;
+ equal(row2.children.length, 3);
+ equal(row2.children[1].querySelectorAll('ct-builder').length, 1);
+ equal(row2.children[2].querySelectorAll('ct-builder').length, 1);
- notEqual(rows[2].children[0].className.indexOf('BUILDING'), -1);
- start();
- });
- } catch(e) {
- reset();
- }
+ notEqual(rows[2].children[0].className.indexOf('BUILDING'), -1);
+ start();
+ });
});
})()
« no previous file with comments | « Tools/GardeningServer/ui/ct-builder-grid.html ('k') | Tools/GardeningServer/ui/ct-commit.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698