Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 404373002: test_runner: Migrate MockColorChooser to Chromium C++ style. (Closed)

Created:
6 years, 5 months ago by Abhishek
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

test_runner: Migrate MockColorChooser to Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to mock_color_chooser. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284689

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -113 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockColorChooser.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/shell/renderer/test_runner/MockColorChooser.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
A + content/shell/renderer/test_runner/mock_color_chooser.h View 1 2 chunks +13 lines, -11 lines 0 comments Download
A content/shell/renderer/test_runner/mock_color_chooser.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
https://codereview.chromium.org/404373002/diff/1/content/shell/renderer/test_runner/mock_color_chooser.cc File content/shell/renderer/test_runner/mock_color_chooser.cc (right): https://codereview.chromium.org/404373002/diff/1/content/shell/renderer/test_runner/mock_color_chooser.cc#newcode10 content/shell/renderer/test_runner/mock_color_chooser.cc:10: using namespace blink; don't use namespace blink, but either ...
6 years, 5 months ago (2014-07-22 07:26:45 UTC) #1
Abhishek
All comments are incorporated. PTAL! https://codereview.chromium.org/404373002/diff/1/content/shell/renderer/test_runner/mock_color_chooser.cc File content/shell/renderer/test_runner/mock_color_chooser.cc (right): https://codereview.chromium.org/404373002/diff/1/content/shell/renderer/test_runner/mock_color_chooser.cc#newcode10 content/shell/renderer/test_runner/mock_color_chooser.cc:10: using namespace blink; On ...
6 years, 5 months ago (2014-07-22 10:49:57 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-22 10:54:36 UTC) #3
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-22 10:54:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/404373002/20001
6 years, 5 months ago (2014-07-22 10:56:07 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 16:03:59 UTC) #6
Message was sent while issue was closed.
Change committed as 284689

Powered by Google App Engine
This is Rietveld 408576698