test_runner: Migrate MockColorChooser to Chromium C++ style.

content/shell/renderer/test_runner/mock_color_chooser.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/shell/renderer/test_runner/MockColorChooser.h"
+#include "content/shell/renderer/test_runner/mock_color_chooser.h"
 
 #include "content/shell/renderer/test_runner/WebTestDelegate.h"
 #include "content/shell/renderer/test_runner/web_test_proxy.h"
 
 using namespace blink;

[jochen (gone - plz use gerrit), 2014/07/22 07:26:45]

don't use namespace blink, but either use the types needed, or add blink::
everywhere

[Abhishek, 2014/07/22 10:49:56]

Done.

 
 namespace content {
 
 namespace {
 class HostMethodTask : public WebMethodTask<MockColorChooser> {
 public:
     typedef void (MockColorChooser::*CallbackMethodType)();
     HostMethodTask(MockColorChooser* object, CallbackMethodType callback)
         : WebMethodTask<MockColorChooser>(object)
-        , m_callback(callback)
+        , callback_(callback)

[jochen (gone - plz use gerrit), 2014/07/22 07:26:45]

, should go on previous line

[Abhishek, 2014/07/22 10:49:56]

Done.

     { }
 
-    virtual void runIfValid() OVERRIDE { (m_object->*m_callback)(); }
+    virtual void runIfValid() OVERRIDE { (m_object->*callback_)(); }
 
 private:
-    CallbackMethodType m_callback;
+    CallbackMethodType callback_;
 };
 }
 
-MockColorChooser::MockColorChooser(blink::WebColorChooserClient* client, WebTestDelegate* delegate, WebTestProxyBase* proxy)
-    : m_client(client)
-    , m_delegate(delegate)
-    , m_proxy(proxy)
+MockColorChooser::MockColorChooser(blink::WebColorChooserClient* client,
+                                   WebTestDelegate* delegate,
+                                   WebTestProxyBase* proxy)
+    : client_(client)
+    , delegate_(delegate)

[jochen (gone - plz use gerrit), 2014/07/22 07:26:45]

same here

[Abhishek, 2014/07/22 10:49:56]

Done.

+    , proxy_(proxy)
 {
-    m_proxy->DidOpenChooser();
+    proxy_->DidOpenChooser();
 }
 
 MockColorChooser::~MockColorChooser()
 {
-    m_proxy->DidCloseChooser();
+    proxy_->DidCloseChooser();
 }
 
 void MockColorChooser::setSelectedColor(const blink::WebColor)

[jochen (gone - plz use gerrit), 2014/07/22 07:26:45]

add parameter name also for unused args

[Abhishek, 2014/07/22 10:49:56]

Done.

 {
 }
 
 void MockColorChooser::endChooser()
 {
-    m_delegate->postDelayedTask(new HostMethodTask(this, &MockColorChooser::invokeDidEndChooser), 0);
+    delegate_->postDelayedTask(new HostMethodTask(this, &MockColorChooser::InvokeDidEndChooser), 0);
 }
 
-void MockColorChooser::invokeDidEndChooser()
+void MockColorChooser::InvokeDidEndChooser()
 {
-    m_client->didEndChooser();
+    client_->didEndChooser();
 }
 
 }  // namespace content