Cast: Build cast targets with GN

Cast: Build cast targets with GN

Most files and targets are compiling and built, except those that depend
on libvpx.

Adding source sets for:
* cast:common
* cast:net
* cast:sender
* cast:receiver
* cast:test_support

Added executables:
* cast:cast_unittests
* cast:udp_proxy
* cast:generate_timecode_audio
* cast:generate_timebar_video

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286723

[brettw, 2014-07-22 17:18:15]

Looks great, just a few minor questions.

https://codereview.chromium.org/404323002/diff/1/media/cast/BUILD.gn
File media/cast/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/BUILD.gn#newcode13
media/cast/BUILD.gn:13: source_set("common") {
Can you put a comment above the 'target_name' in the .gyp files listing the GN
target for each one? Like this:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/wm/wm.gyp&q=%22...

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
File media/cast/logging/proto/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
media/cast/logging/proto/BUILD.gn:15: direct_dependent_configs = [
Can this be:
forward_dependent_configs = [ ":cast_logging_proto" ]
instead?

https://codereview.chromium.org/404323002/diff/1/media/cast/test/proto/BUILD.gn
File media/cast/test/proto/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/test/proto/BUILD....
media/cast/test/proto/BUILD.gn:12: direct_dependent_configs = [
Ditto

[Alpha Left Google, 2014-07-24 18:24:31]

https://codereview.chromium.org/404323002/diff/1/media/cast/BUILD.gn
File media/cast/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/BUILD.gn#newcode13
media/cast/BUILD.gn:13: source_set("common") {
On 2014/07/22 17:18:14, brettw wrote:
> Can you put a comment above the 'target_name' in the .gyp files listing the GN
> target for each one? Like this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/wm/wm.gyp&q=%22...

Done.

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
File media/cast/logging/proto/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
media/cast/logging/proto/BUILD.gn:15: direct_dependent_configs = [
On 2014/07/22 17:18:14, brettw wrote:
> Can this be:
> forward_dependent_configs = [ ":cast_logging_proto" ]
> instead?

I tried but it says:

ERROR at //media/cast/logging/proto/BUILD.gn:15:33: Assignment had no effect.
  forward_dependent_configs = [ ":cast_logging_proto" ]
                                ^---------------------
You set the variable "forward_dependent_configs" here and it was unused before
it went
out of scope.

[brettw, 2014-07-24 18:27:59]

In the future also see "gn help" for what's available if you haven't noticed
that already.

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
File media/cast/logging/proto/BUILD.gn (right):

https://codereview.chromium.org/404323002/diff/1/media/cast/logging/proto/BUI...
media/cast/logging/proto/BUILD.gn:15: direct_dependent_configs = [
On 2014/07/24 18:24:30, Alpha wrote:
> On 2014/07/22 17:18:14, brettw wrote:
> > Can this be:
> > forward_dependent_configs = [ ":cast_logging_proto" ]
> > instead?
> 
> I tried but it says:
> 
> ERROR at //media/cast/logging/proto/BUILD.gn:15:33: Assignment had no effect.
>   forward_dependent_configs = [ ":cast_logging_proto" ]
>                                 ^---------------------
> You set the variable "forward_dependent_configs" here and it was unused before
> it went
> out of scope.

Sorry, "forward_dependent_configs_from"

[brettw, 2014-07-24 18:28:43]

LGTM with that fixed

[Alpha Left Google, 2014-07-24 20:54:03]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-24 20:56:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/404323002/40001

[commit-bot: I haz the power, 2014-07-25 01:00:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-25 01:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 01:04:27]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Alpha Left Google, 2014-07-25 22:29:24]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-25 22:31:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/404323002/60001

[commit-bot: I haz the power, 2014-07-26 05:02:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-26 17:09:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-07-26 18:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-26 18:10:18]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Alpha Left Google, 2014-07-29 01:54:00]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:56:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/404323002/60001

[commit-bot: I haz the power, 2014-07-29 02:02:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-07-29 02:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 02:07:10]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Alpha Left Google, 2014-07-30 21:50:39]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-30 21:51:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/404323002/100001

[Alpha Left Google, 2014-07-30 23:14:20]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-30 23:17:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/404323002/120001

[commit-bot: I haz the power, 2014-07-31 08:56:32]

Change committed as 286723