Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: media/cast/net/rtp/frame_buffer_unittest.cc

Issue 404323002: Cast: Build cast targets with GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/net/rtcp/rtcp_sender_unittest.cc ('k') | media/cast/net/rtp/framer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/rtp/frame_buffer_unittest.cc
diff --git a/media/cast/net/rtp/frame_buffer_unittest.cc b/media/cast/net/rtp/frame_buffer_unittest.cc
index 69ce93dbbb023644a2d2c039255bd0ac835d8f8a..64b2734b552fd5690e4bb776a45c16485e4eef05 100644
--- a/media/cast/net/rtp/frame_buffer_unittest.cc
+++ b/media/cast/net/rtp/frame_buffer_unittest.cc
@@ -29,7 +29,7 @@ TEST_F(FrameBufferTest, OnePacketInsertSanity) {
rtp_header_.is_key_frame = true;
rtp_header_.frame_id = 5;
rtp_header_.reference_frame_id = 5;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
EncodedFrame frame;
EXPECT_TRUE(buffer_.AssembleEncodedFrame(&frame));
EXPECT_EQ(EncodedFrame::KEY, frame.dependency);
@@ -45,7 +45,7 @@ TEST_F(FrameBufferTest, EmptyBuffer) {
}
TEST_F(FrameBufferTest, DefaultOnePacketFrame) {
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
EXPECT_TRUE(buffer_.Complete());
EXPECT_FALSE(buffer_.is_key_frame());
EncodedFrame frame;
@@ -56,11 +56,11 @@ TEST_F(FrameBufferTest, DefaultOnePacketFrame) {
TEST_F(FrameBufferTest, MultiplePacketFrame) {
rtp_header_.is_key_frame = true;
rtp_header_.max_packet_id = 2;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
EXPECT_TRUE(buffer_.Complete());
EXPECT_TRUE(buffer_.is_key_frame());
@@ -71,19 +71,19 @@ TEST_F(FrameBufferTest, MultiplePacketFrame) {
TEST_F(FrameBufferTest, IncompleteFrame) {
rtp_header_.max_packet_id = 4;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
// Increment again - skip packet #2.
++rtp_header_.packet_id;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
++rtp_header_.packet_id;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
EXPECT_FALSE(buffer_.Complete());
// Insert missing packet.
rtp_header_.packet_id = 2;
- buffer_.InsertPacket(payload_.data(), payload_.size(), rtp_header_);
+ buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
EXPECT_TRUE(buffer_.Complete());
}
« no previous file with comments | « media/cast/net/rtcp/rtcp_sender_unittest.cc ('k') | media/cast/net/rtp/framer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698