Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: ui/base/ime/remote_input_method_win_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_win.cc ('k') | ui/chromeos/touch_exploration_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/remote_input_method_win_unittest.cc
diff --git a/ui/base/ime/remote_input_method_win_unittest.cc b/ui/base/ime/remote_input_method_win_unittest.cc
index 3fa8be0cf32d813e6695fc000436041ee6e064b7..40269de8eee48a818b7e9937290b864b82a58b41 100644
--- a/ui/base/ime/remote_input_method_win_unittest.cc
+++ b/ui/base/ime/remote_input_method_win_unittest.cc
@@ -548,7 +548,7 @@ TEST(RemoteInputMethodWinTest, DispatchKeyEvent_NativeKeyEvent) {
scoped_ptr<InputMethod> input_method(CreateRemoteInputMethodWin(&delegate_));
const MSG wm_keydown = { NULL, WM_KEYDOWN, ui::VKEY_A };
- ui::KeyEvent native_keydown(wm_keydown, false);
+ ui::KeyEvent native_keydown(wm_keydown);
// This must not cause a crash.
EXPECT_FALSE(input_method->DispatchKeyEvent(native_keydown));
@@ -590,7 +590,7 @@ TEST(RemoteInputMethodWinTest, DispatchKeyEvent_NativeCharEvent) {
scoped_ptr<InputMethod> input_method(CreateRemoteInputMethodWin(&delegate_));
const MSG wm_char = { NULL, WM_CHAR, 'A', 0 };
- ui::KeyEvent native_char(wm_char, true);
+ ui::KeyEvent native_char(wm_char);
// This must not cause a crash.
EXPECT_FALSE(input_method->DispatchKeyEvent(native_char));
@@ -633,7 +633,7 @@ TEST(RemoteInputMethodWinTest, DispatchKeyEvent_FabricatedKeyDown) {
MockTextInputClient mock_text_input_client;
scoped_ptr<InputMethod> input_method(CreateRemoteInputMethodWin(&delegate_));
- ui::KeyEvent fabricated_keydown(ui::ET_KEY_PRESSED, ui::VKEY_A, 0, false);
+ ui::KeyEvent fabricated_keydown(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE);
fabricated_keydown.set_character(L'A');
// This must not cause a crash.
@@ -684,8 +684,7 @@ TEST(RemoteInputMethodWinTest, DispatchKeyEvent_FabricatedChar) {
MockTextInputClient mock_text_input_client;
scoped_ptr<InputMethod> input_method(CreateRemoteInputMethodWin(&delegate_));
- ui::KeyEvent fabricated_char(ui::ET_KEY_PRESSED, ui::VKEY_A, 0, true);
- fabricated_char.set_character(L'A');
+ ui::KeyEvent fabricated_char(L'A', ui::VKEY_A, ui::EF_NONE);
// This must not cause a crash.
EXPECT_TRUE(input_method->DispatchKeyEvent(fabricated_char));
« no previous file with comments | « ui/base/ime/input_method_win.cc ('k') | ui/chromeos/touch_exploration_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698