Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404143002: MIPS: Never record safepoint with doubles. (Closed)

Created:
6 years, 5 months ago by balazs.kilvady
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Never record safepoint with doubles. Port r22496 (f9dde0f) and r22498 (7a16d69) BUG= R=dusan.milosavljevic@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22527

Patch Set 1 #

Patch Set 2 : Keep stubs. #

Total comments: 2

Patch Set 3 : Fix semicolons. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -259 lines) Patch
M src/mips/code-stubs-mips.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 3 chunks +8 lines, -25 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 2 chunks +11 lines, -46 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 12 chunks +12 lines, -22 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 3 chunks +8 lines, -24 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 2 chunks +11 lines, -46 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 12 chunks +12 lines, -22 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
balazs.kilvady
6 years, 5 months ago (2014-07-21 17:22:31 UTC) #1
paul.l...
You should not remove the code-stubs here. The stubs that Dusan added gave us a ...
6 years, 5 months ago (2014-07-21 18:00:00 UTC) #2
balazs.kilvady
[Re]StoreRegistersStateStub code-stubs re-added.
6 years, 5 months ago (2014-07-22 10:51:48 UTC) #3
dusmil.imgtec
https://codereview.chromium.org/404143002/diff/20001/src/mips64/lithium-codegen-mips64.cc File src/mips64/lithium-codegen-mips64.cc (right): https://codereview.chromium.org/404143002/diff/20001/src/mips64/lithium-codegen-mips64.cc#newcode2765 src/mips64/lithium-codegen-mips64.cc:2765: PushSafepointRegistersScope scope(this);; Extra semicolon. Remove others in this file.
6 years, 5 months ago (2014-07-22 11:15:01 UTC) #4
balazs.kilvady
https://codereview.chromium.org/404143002/diff/20001/src/mips64/lithium-codegen-mips64.cc File src/mips64/lithium-codegen-mips64.cc (right): https://codereview.chromium.org/404143002/diff/20001/src/mips64/lithium-codegen-mips64.cc#newcode2765 src/mips64/lithium-codegen-mips64.cc:2765: PushSafepointRegistersScope scope(this);; On 2014/07/22 11:15:01, dusmil.imgtec wrote: > Extra ...
6 years, 5 months ago (2014-07-22 11:30:44 UTC) #5
dusmil.imgtec
LGTM
6 years, 5 months ago (2014-07-22 13:04:27 UTC) #6
balazs.kilvady
6 years, 5 months ago (2014-07-22 14:35:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r22527 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698