Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 40403002: Compute clipped src rect once in tiled bitmap draws (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Compute clipped src rect once in tiled bitmap draws Committed: http://code.google.com/p/skia/source/detail?r=11962

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M include/gpu/SkGpuDevice.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +13 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
Follow up to https://codereview.chromium.org/31033002/
7 years, 2 months ago (2013-10-24 15:28:14 UTC) #1
robertphillips
lgtm + 1 question/comment. https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1238 src/gpu/SkGpuDevice.cpp:1238: int tileSize) { It seems ...
7 years, 2 months ago (2013-10-24 15:36:53 UTC) #2
bsalomon
https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1238 src/gpu/SkGpuDevice.cpp:1238: int tileSize) { On 2013/10/24 15:36:54, robertphillips wrote: > ...
7 years, 2 months ago (2013-10-24 15:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/40403002/20001
7 years, 1 month ago (2013-10-25 14:13:08 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 14:58:17 UTC) #5
Message was sent while issue was closed.
Change committed as 11962

Powered by Google App Engine
This is Rietveld 408576698