Compute clipped src rect once in tiled bitmap draws

Compute clipped src rect once in tiled bitmap draws

Committed: http://code.google.com/p/skia/source/detail?r=11962

[bsalomon, 2013-10-24 15:28:14]

Follow up to https://codereview.chromium.org/31033002/

[robertphillips, 2013-10-24 15:36:53]

lgtm + 1 question/comment.

https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1238: int tileSize) {
It seems like we should have an early out in case clippedSrcIRect is empty.

[bsalomon, 2013-10-24 15:43:38]

https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/40403002/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1238: int tileSize) {
On 2013/10/24 15:36:54, robertphillips wrote:
> It seems like we should have an early out in case clippedSrcIRect is empty.

I suspect that it's not worth it, that it's almost never empty and most cases
when it would be would have been caught upstack (SkCanvas).

We should probably consider rewriting these loop to compute start and end values
for x and y rather than always looping from 0 to nx and ny, though. I just
didn't want to get into that for this CL.

[commit-bot: I haz the power, 2013-10-25 14:13:08]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/40403002/20001

[commit-bot: I haz the power, 2013-10-25 14:58:17]

Change committed as 11962