Make GetCustomFontRenderParams() pass font style.

ui/gfx/font_render_params.h

Index: ui/gfx/font_render_params.h
diff --git a/ui/gfx/font_render_params.h b/ui/gfx/font_render_params.h
index a6e736bfaacaf0062a368c6dd1e4005712597fa3..a63b42df3fdfe41d24940e4385e2c8996a99d4b0 100644
--- a/ui/gfx/font_render_params.h
+++ b/ui/gfx/font_render_params.h
@@ -67,13 +67,13 @@ GFX_EXPORT const FontRenderParams& GetDefaultWebKitFontRenderParams();
 // Returns the appropriate parameters for rendering the font described by the
 // passed-in-arguments, any of which may be NULL. If |family_out| is non-NULL,
 // it will be updated to contain the recommended font family from |family_list|.
-// TODO(derat): Also accept the font style, so that its bold and italic states
-// can be passed to Fontconfig in the Linux implementation.
+// |style| optionally points to a bitmap of Font::FontStyle values.

[msw, 2014/07/19 03:11:51]

nit: did you mean bitmask?

[Daniel Erat, 2014/07/19 14:29:05]

i actually wasn't sure of the correct terminology for this. i'd probably
consider Font::BOLD to be a bitmask, but i was less sure of the right term for
several of these bits OR-ed together. this stack overflow answer suggests that
it's a bitmap
(http://stackoverflow.com/questions/9728102/what-is-the-difference-between-bit...),
but i think i prefer wikipedia's usage of "bit field"
(http://en.wikipedia.org/wiki/Bit_field), so i'll switch to that if it's okay
with you.

[msw, 2014/07/19 17:16:22]

Acknowledged.

 GFX_EXPORT FontRenderParams GetCustomFontRenderParams(
     bool for_web_contents,
     const std::vector<std::string>* family_list,
     const int* pixel_size,
     const int* point_size,
+    const int* style,

[Daniel Erat, 2014/07/19 01:34:44]

i don't plan on adding any more arguments anytime soon, but let me know if you
think that this list is unwieldy enough now (especially with all these int
pointers) that passing the query parameters in a struct would be better.

[msw, 2014/07/19 03:11:52]

Eh, it's certainly not pretty, but it seems okay.

     std::string* family_out);
 
 }  // namespace gfx