Make GetCustomFontRenderParams() pass font style.

ui/gfx/font_render_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_FONT_RENDER_PARAMS_H_
 #define UI_GFX_FONT_RENDER_PARAMS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 49 matching lines @@
 // Returns the system's default parameters for font rendering.
 GFX_EXPORT const FontRenderParams& GetDefaultFontRenderParams();
 
 // Returns the system's default parameters for WebKit font rendering.
 // TODO(derat): Rename to GetDefaultFontRenderParamsForWebContents().
 GFX_EXPORT const FontRenderParams& GetDefaultWebKitFontRenderParams();
 
 // Returns the appropriate parameters for rendering the font described by the
 // passed-in-arguments, any of which may be NULL. If |family_out| is non-NULL,
 // it will be updated to contain the recommended font family from |family_list|.
-// TODO(derat): Also accept the font style, so that its bold and italic states
-// can be passed to Fontconfig in the Linux implementation.
+// |style| optionally points to a bitmap of Font::FontStyle values.

[msw, 2014/07/19 03:11:51]

nit: did you mean bitmask?

[Daniel Erat, 2014/07/19 14:29:05]

i actually wasn't sure of the correct terminology for this. i'd probably
consider Font::BOLD to be a bitmask, but i was less sure of the right term for
several of these bits OR-ed together. this stack overflow answer suggests that
it's a bitmap
(http://stackoverflow.com/questions/9728102/what-is-the-difference-between-bit...),
but i think i prefer wikipedia's usage of "bit field"
(http://en.wikipedia.org/wiki/Bit_field), so i'll switch to that if it's okay
with you.

[msw, 2014/07/19 17:16:22]

Acknowledged.

 GFX_EXPORT FontRenderParams GetCustomFontRenderParams(
     bool for_web_contents,
     const std::vector<std::string>* family_list,
     const int* pixel_size,
     const int* point_size,
+    const int* style,

[Daniel Erat, 2014/07/19 01:34:44]

i don't plan on adding any more arguments anytime soon, but let me know if you
think that this list is unwieldy enough now (especially with all these int
pointers) that passing the query parameters in a struct would be better.

[msw, 2014/07/19 03:11:52]

Eh, it's certainly not pretty, but it seems okay.

     std::string* family_out);
 
 }  // namespace gfx
 
 #endif  // UI_GFX_FONT_RENDER_PARAMS_H_