Issue 403853002: Revert 284177 "Make NativeViewHostAura clipping window non-focus..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403853002: Revert 284177 "Make NativeViewHostAura clipping window non-focus..." (Closed)

Created:
6 years, 5 months ago by waffles

Modified:
6 years, 5 months ago

Reviewers:
calamity

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 284177 "Make NativeViewHostAura clipping window non-focus..." Reason for revert: use-after-free with #3 0x897b331 in views::NativeViewHostAura::ClippingWindowDelegate::CanFocus() ui/views/controls/native/native_view_host_aura.cc:43 in the stack trace. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5437 > Make NativeViewHostAura clipping window non-focusable. > > This CL fixes an issue where the clipping window would get a focus event > when the SadTab was displayed causing the focus to be set to nothing, > disabling all keyboard shortcuts. > > This is fixed by making the clipping window nonfocusable. > > BUG=393119 > > Review URL: https://codereview.chromium.org/397493005 TBR=calamity@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284196

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -47 lines)			Patch
	M	trunk/src/ui/views/controls/native/native_view_host_aura.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	trunk/src/ui/views/controls/native/native_view_host_aura.cc	View		1 chunk	+1 line, -43 lines	0 comments	Download

Total messages: 2 (0 generated)

waffles

6 years, 5 months ago (2014-07-18 21:07:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r284196 (tree was closed).