Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: trunk/src/ui/views/controls/native/native_view_host_aura.cc

Issue 403853002: Revert 284177 "Make NativeViewHostAura clipping window non-focus..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ui/views/controls/native/native_view_host_aura.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/views/controls/native/native_view_host_aura.cc
===================================================================
--- trunk/src/ui/views/controls/native/native_view_host_aura.cc (revision 284194)
+++ trunk/src/ui/views/controls/native/native_view_host_aura.cc (working copy)
@@ -8,58 +8,16 @@
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/focus_client.h"
#include "ui/aura/window.h"
-#include "ui/aura/window_delegate.h"
#include "ui/base/cursor/cursor.h"
-#include "ui/base/hit_test.h"
#include "ui/views/controls/native/native_view_host.h"
#include "ui/views/view_constants_aura.h"
#include "ui/views/widget/widget.h"
namespace views {
-class NativeViewHostAura::ClippingWindowDelegate : public aura::WindowDelegate {
- public:
- explicit ClippingWindowDelegate(const NativeViewHost* host) : host_(host) {}
- virtual ~ClippingWindowDelegate() {}
-
- virtual gfx::Size GetMinimumSize() const OVERRIDE { return gfx::Size(); }
- virtual gfx::Size GetMaximumSize() const OVERRIDE { return gfx::Size(); }
- virtual void OnBoundsChanged(const gfx::Rect& old_bounds,
- const gfx::Rect& new_bounds) OVERRIDE {}
- virtual gfx::NativeCursor GetCursor(const gfx::Point& point) OVERRIDE {
- return gfx::kNullCursor;
- }
- virtual int GetNonClientComponent(const gfx::Point& point) const OVERRIDE {
- return HTCLIENT;
- }
- virtual bool ShouldDescendIntoChildForEventHandling(
- aura::Window* child,
- const gfx::Point& location) OVERRIDE { return true; }
- virtual bool CanFocus() OVERRIDE {
- // Ask the hosted native view's delegate because directly calling
- // aura::Window::CanFocus() will call back into this when checking whether
- // parents can focus.
- return host_->native_view() && host_->native_view()->delegate()
- ? host_->native_view()->delegate()->CanFocus()
- : true;
- }
- virtual void OnCaptureLost() OVERRIDE {}
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE {}
- virtual void OnDeviceScaleFactorChanged(float device_scale_factor) OVERRIDE {}
- virtual void OnWindowDestroying(aura::Window* window) OVERRIDE {}
- virtual void OnWindowDestroyed(aura::Window* window) OVERRIDE {}
- virtual void OnWindowTargetVisibilityChanged(bool visible) OVERRIDE {}
- virtual bool HasHitTestMask() const OVERRIDE { return false; }
- virtual void GetHitTestMask(gfx::Path* mask) const OVERRIDE {}
-
- private:
- const NativeViewHost* host_;
-};
-
NativeViewHostAura::NativeViewHostAura(NativeViewHost* host)
: host_(host),
- clipping_window_delegate_(new ClippingWindowDelegate(host)),
- clipping_window_(clipping_window_delegate_.get()) {
+ clipping_window_(NULL) {
clipping_window_.Init(aura::WINDOW_LAYER_NOT_DRAWN);
clipping_window_.set_owned_by_parent(false);
clipping_window_.SetName("NativeViewHostAuraClip");
« no previous file with comments | « trunk/src/ui/views/controls/native/native_view_host_aura.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698