Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 40373002: Partially revert "Ignore should-scroll-on-main-thread if main frame is not scrollable" (Closed)

Created:
7 years, 2 months ago by ajuma
Modified:
7 years, 1 month ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, shawnsingh, hartmanng
Visibility:
Public.

Description

Partially revert "Ignore should-scroll-on-main-thread if main frame is not scrollable" This partially reverts Blink r157644 (https://codereview.chromium.org/23641004), which can cause a frame that needs to scroll on the main thread to incorrectly scroll on the compositor thread, causing non-composited fixed position elements to bounce around. BUG=296823 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -101 lines) Patch
D LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html View 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ajuma
PTAL. The problem is that ScrollingCoordinator is depending on whether the FrameView is scrollable, but ...
7 years, 2 months ago (2013-10-24 15:05:53 UTC) #1
Ian Vollick
On 2013/10/24 15:05:53, ajuma wrote: > PTAL. > > The problem is that ScrollingCoordinator is ...
7 years, 1 month ago (2013-10-28 14:38:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/40373002/1
7 years, 1 month ago (2013-10-28 14:38:53 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 14:44:14 UTC) #4
Message was sent while issue was closed.
Change committed as 160720

Powered by Google App Engine
This is Rietveld 408576698