Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 40373002: Partially revert "Ignore should-scroll-on-main-thread if main frame is not scrollable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 40373002: Partially revert "Ignore should-scroll-on-main-thread if main frame is not scrollable" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 7e5c633cd1d49d41131fd5077e1c2a89f02ef5c5..2ac84550aedf74064e3d3b39b33b7caa9bae8bce 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -825,11 +825,8 @@ bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(Frame

MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() const

{

- // The main thread scrolling reasons are applicable to scrolls of the main

- // frame. If it does not exist or if it is not scrollable, there is no

- // reason to force main thread scrolling.

FrameView* frameView = m_page->mainFrame()->view();

- if (!frameView || !frameView->isScrollable())

+ if (!frameView)

return static_cast<MainThreadScrollingReasons>(0);

MainThreadScrollingReasons mainThreadScrollingReasons = (MainThreadScrollingReasons)0;