Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 403593002: Improve messaging for shared modules on chrome://extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/extensions/extension_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index dbadeb63c9fe632ae98a6a408891236df33b0fe4..03d1faffd0c87fa6f704a3bb2eab9fe93431e077 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -112,34 +112,6 @@ namespace {
// Wait this many seconds after an extensions becomes idle before updating it.
const int kUpdateIdleDelay = 5;
-bool IsCWSSharedModule(const Extension* extension) {
- return extension->from_webstore() &&
- SharedModuleInfo::IsSharedModule(extension);
-}
-
-class SharedModuleProvider : public extensions::ManagementPolicy::Provider {
- public:
- SharedModuleProvider() {}
- virtual ~SharedModuleProvider() {}
-
- virtual std::string GetDebugPolicyProviderName() const OVERRIDE {
- return "SharedModuleProvider";
- }
-
- virtual bool UserMayModifySettings(const Extension* extension,
- base::string16* error) const OVERRIDE {
- return !IsCWSSharedModule(extension);
- }
-
- virtual bool MustRemainEnabled(const Extension* extension,
- base::string16* error) const OVERRIDE {
- return IsCWSSharedModule(extension);
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(SharedModuleProvider);
-};
-
} // namespace
// ExtensionService.
@@ -355,8 +327,6 @@ ExtensionService::ExtensionService(Profile* profile,
new extensions::ExtensionActionStorageManager(profile_));
#endif
- shared_module_policy_provider_.reset(new SharedModuleProvider);
-
// How long is the path to the Extensions directory?
UMA_HISTOGRAM_CUSTOM_COUNTS("Extensions.ExtensionRootPathLength",
install_directory_.value().length(), 0, 500, 100);
@@ -472,9 +442,6 @@ void ExtensionService::Init() {
// rather than running immediately at startup.
CheckForExternalUpdates();
- system_->management_policy()->RegisterProvider(
- shared_module_policy_provider_.get());
-
LoadGreylistFromPrefs();
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/extensions/extension_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698