Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 403593002: Improve messaging for shared modules on chrome://extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index b3a8f29cc23c10157479827b2551a56ffac472db..b48b683e747843d28f9ee9498776101fb898722b 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -85,7 +85,8 @@ cr.define('options', function() {
if (!extension.enabled || extension.terminated)
node.classList.add('inactive-extension');
- if (extension.managedInstall) {
+ if (extension.managedInstall ||
+ extension.dependentExtensions.length > 0) {
node.classList.add('may-not-modify');
node.classList.add('may-not-remove');
} else if (extension.suspiciousInstall || extension.corruptInstall) {
@@ -236,12 +237,13 @@ cr.define('options', function() {
// The 'Enabled' checkbox.
var enable = node.querySelector('.enable-checkbox');
enable.hidden = false;
- var managedOrHosedExtension = extension.managedInstall ||
- extension.suspiciousInstall ||
- extension.corruptInstall;
- enable.querySelector('input').disabled = managedOrHosedExtension;
+ var enableCheckboxDisabled = extension.managedInstall ||
+ extension.suspiciousInstall ||
+ extension.corruptInstall ||
+ extension.dependentExtensions.length > 0;
+ enable.querySelector('input').disabled = enableCheckboxDisabled;
- if (!managedOrHosedExtension) {
+ if (!enableCheckboxDisabled) {
enable.addEventListener('click', function(e) {
// When e.target is the label instead of the checkbox, it doesn't
// have the checked property and the state of the checkbox is
@@ -312,6 +314,18 @@ cr.define('options', function() {
}
}
+ if (extension.dependentExtensions.length > 0) {
+ var dependentMessage =
+ node.querySelector('.dependent-extensions-message');
+ dependentMessage.hidden = false;
+ var dependentList = dependentMessage.querySelector('ul');
+ extension.dependentExtensions.forEach(function(id) {
+ var li = document.createElement('li');
+ li.innerText = id;
+ dependentList.appendChild(li);
+ });
+ }
+
// Then active views.
if (extension.views.length > 0) {
var activeViews = node.querySelector('.active-views');
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698