Move dom_storage test data file from webkit/ to content/

Move dom_storage test data file from webkit/ to content/

BUG=338338
TEST=content_unittests
R=jam@chromium.org,jamesr@chromium.org
TBR=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284348

[jam, 2014-07-17 18:16:45]

the test is failing?

[tfarina, 2014-07-18 02:18:44]

John, tests passes locally:

$ out/Debug/content_unittests --gtest_filter=DOMStorageDatabaseTest.*
--test-launcher-bot-mode
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Enabling defaults optimized for continuous integration bots.
Using sharding settings from environment. This is shard 0/1
Using 4 parallel jobs.
[1/11] DOMStorageDatabaseTest.TestCanOpenFileThatIsNotADatabase (516 ms)
[2/11] DOMStorageDatabaseTest.SimpleOpenAndClose (2 ms)
[3/11] DOMStorageDatabaseTest.CloseEmptyDatabaseDeletesFile (837 ms)
[4/11] DOMStorageDatabaseTest.TestLazyOpenIsLazy (208 ms)
[5/11] DOMStorageDatabaseTest.TestDetectSchemaVersion (4 ms)
[6/11] DOMStorageDatabaseTest.TestLazyOpenUpgradesDatabase (169 ms)
[7/11] DOMStorageDatabaseTest.SimpleWriteAndReadBack (6 ms)
[8/11] DOMStorageDatabaseTest.WriteWithClear (5 ms)
[9/11] DOMStorageDatabaseTest.UpgradeFromV1ToV2WithData (6 ms)
[10/11] DOMStorageDatabaseTest.TestSimpleRemoveOneValue (3 ms)
[11/11] DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase (1 ms)
SUCCESS: all tests passed.
Tests took 1 seconds.

My guess is that trybots have issues with binaries. Jason (copied) may be able
to confirm this.

I think I will have to copy the database first, in a separate CL. Is that fine
by you?

[jam, 2014-07-18 02:42:27]

On Thu, Jul 17, 2014 at 7:18 PM, <tfarina@chromium.org> wrote:

> John, tests passes locally:
>
> $ out/Debug/content_unittests --gtest_filter=DOMStorageDatabaseTest.*
> --test-launcher-bot-mode
> IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
> own process. For debugging a test inside a debugger, use the
> --gtest_filter=<your_test_name> flag along with
> --single-process-tests.
> Enabling defaults optimized for continuous integration bots.
> Using sharding settings from environment. This is shard 0/1
> Using 4 parallel jobs.
> [1/11] DOMStorageDatabaseTest.TestCanOpenFileThatIsNotADatabase (516 ms)
> [2/11] DOMStorageDatabaseTest.SimpleOpenAndClose (2 ms)
> [3/11] DOMStorageDatabaseTest.CloseEmptyDatabaseDeletesFile (837 ms)
> [4/11] DOMStorageDatabaseTest.TestLazyOpenIsLazy (208 ms)
> [5/11] DOMStorageDatabaseTest.TestDetectSchemaVersion (4 ms)
> [6/11] DOMStorageDatabaseTest.TestLazyOpenUpgradesDatabase (169 ms)
> [7/11] DOMStorageDatabaseTest.SimpleWriteAndReadBack (6 ms)
> [8/11] DOMStorageDatabaseTest.WriteWithClear (5 ms)
> [9/11] DOMStorageDatabaseTest.UpgradeFromV1ToV2WithData (6 ms)
> [10/11] DOMStorageDatabaseTest.TestSimpleRemoveOneValue (3 ms)
> [11/11] DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase (1 ms)
> SUCCESS: all tests passed.
> Tests took 1 seconds.
>
> My guess is that trybots have issues with binaries. Jason (copied) may be
> able
> to confirm this.
>
> I think I will have to copy the database first, in a separate CL. Is that
> fine
> by you?
>

sure. you can tbr the file copy to me. if this cl has green try runs after
that, lgtm

>
> https://codereview.chromium.org/403453002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jam, 2014-07-18 02:45:59]

lgtm

[tfarina, 2014-07-18 02:51:14]

On Thu, Jul 17, 2014 at 11:45 PM, <jam@chromium.org> wrote:

> lgtm
>
> Did you mean to 'lgtm' https://codereview.chromium.org/394403002/
instead? :)


>
> https://codereview.chromium.org/403453002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-07-19 01:12:44]

John, I'm making the copy of the database here ->
https://codereview.chromium.org/405753003

[tfarina, 2014-07-19 20:57:28]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-19 20:57:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/403453002/40001

[commit-bot: I haz the power, 2014-07-19 21:43:02]

Change committed as 284348