Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 405753003: Make a copy of webcore_test_database in content test data. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, darin (slow to review), jochen (gone - plz use gerrit), jamesr, pilgrim_google
Project:
chromium
Visibility:
Public.

Description

Make a copy of webcore_test_database in content test data. Apparently tryserver is not capable of doing tries with binary data so we need to copy first then update the test. This was discovered while doing https://codereview.chromium.org/403453002/. BUG=338338 TEST=None TBR=jam@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + content/test/data/dom_storage/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/dom_storage/webcore_test_database.localstorage View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
6 years, 5 months ago (2014-07-19 01:13:20 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-19 14:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/405753003/1
6 years, 5 months ago (2014-07-19 14:26:22 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 18:21:22 UTC) #4
Message was sent while issue was closed.
Change committed as 284339

Powered by Google App Engine
This is Rietveld 408576698