Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 403093002: Merge all logic in PageMeasurementResults to PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
index 6ec1fdb8ff75d0157da9142a6d5bdaeb1dbe9fd9..6ac8f77278350b39efb2ce8da5fa1eefd8eaacd4 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
@@ -70,6 +70,7 @@ class TimelineBasedMetricTestData(object):
self._renderer_thread.name = 'CrRendererMain'
self._results = page_measurement_results.PageMeasurementResults()
self._metric = None
+ self._ps = None
@property
def results(self):
@@ -89,13 +90,13 @@ class TimelineBasedMetricTestData(object):
self._model.FinalizeImport()
self._metric = tbm_module._TimelineBasedMetrics( # pylint: disable=W0212
self._model, self._renderer_thread, GetMetricFromMetricType)
- ps = page_set.PageSet(file_path=os.path.dirname(__file__))
- ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')
- self._results.WillMeasurePage(ps.pages[0])
+ self._ps = page_set.PageSet(file_path=os.path.dirname(__file__))
+ self._ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')
+ self._results.StartTest(self._ps.pages[0])
def AddResults(self):
self._metric.AddResults(self._results)
- self._results.DidMeasurePage()
+ self._results.StopTest(self._ps.pages[0])
class TimelineBasedMetricsTests(unittest.TestCase):

Powered by Google App Engine
This is Rietveld 408576698