Merge all logic in PageMeasurementResults to PageTestResults.

tools/telemetry/telemetry/results/page_test_results.py

Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index 512b891775efdba276af66a076601f526862a944..8d960a2382e7c2134fc33e969666a2df869409e3 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -11,9 +11,12 @@ from telemetry import value as value_module
 from telemetry.value import failure
 
 class PageTestResults(object):
-  def __init__(self, output_stream=None):
+  def __init__(self, output_stream=None, trace_tag=''):

[nednguyen, 2014/07/25 16:14:45]

It's not clear to me what "trace_tage" means and how it is used. Can you add
documentation for it?

[chrishenry, 2014/07/25 16:24:28]

I don't know what it is either. Seems to only be used from Buildbot. Also,
documentation for --output-trace-tag is pretty vague: "Append a tag to the key
of each result trace."

Here is the final usage:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

Still no clue what it's doing.

     super(PageTestResults, self).__init__()
     self._output_stream = output_stream
+    self._trace_tag = trace_tag
+    self._current_page = None
+
     # TODO(chrishenry,eakuefner): Remove self.successes once they can
     # be inferred.
     self.successes = []
@@ -41,6 +44,10 @@ class PageTestResults(object):
     return self._all_summary_values
 
   @property
+  def current_page(self):
+    return self._current_page

[nednguyen, 2014/07/25 16:14:45]

I think the current_page thing is lame, we should get rid of it eventually.

If so, the end goal of StartTest & StopTest is that they are only used for
reporting the status of test, is that right?

[chrishenry, 2014/07/25 16:24:28]

Perhaps. A lot of the usage of current_page is what you added as you cleaned up
Add(). I don't think it's super critical to clean this up tho. It seems ok,
especially since we'll likely also have page_run information soon. <- this
answer your second question too, StartTest will create a new page_run.

+
+  @property
   def pages_that_succeeded(self):
     """Returns the set of pages that succeeded."""
     pages = set(value.page for value in self._all_page_specific_values)
@@ -61,10 +68,10 @@ class PageTestResults(object):
     return ''.join(traceback.format_exception(*err))
 
   def StartTest(self, page):
-    pass
+    self._current_page = page
 
-  def StopTest(self, page):
-    pass
+  def StopTest(self, page):  # pylint: disable=W0613
+    self._current_page = None
 
   def AddValue(self, value):
     self._ValidateValue(value)