Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results.py

Issue 403093002: Merge all logic in PageMeasurementResults to PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_measurement_results.py
diff --git a/tools/telemetry/telemetry/results/page_measurement_results.py b/tools/telemetry/telemetry/results/page_measurement_results.py
index dea7b2489452ad8d8caa6a6622f8e94c3bc539c4..5b12c1e7803ca6af094de1ba3c063453cb09f5a3 100644
--- a/tools/telemetry/telemetry/results/page_measurement_results.py
+++ b/tools/telemetry/telemetry/results/page_measurement_results.py
@@ -3,36 +3,8 @@
# found in the LICENSE file.
from telemetry.results import page_test_results
-from telemetry.value import failure
class PageMeasurementResults(page_test_results.PageTestResults):
def __init__(self, output_stream=None, trace_tag=''):
- super(PageMeasurementResults, self).__init__(output_stream)
+ super(PageMeasurementResults, self).__init__(output_stream, trace_tag)
self._trace_tag = trace_tag
-
- self._current_page = None
- self._page_specific_values_for_current_page = None
-
- @property
- def current_page(self):
- return self._current_page
-
- @property
- def page_specific_values_for_current_page(self):
- assert self._current_page
- return self._page_specific_values_for_current_page
-
- def WillMeasurePage(self, page):
- assert not self._current_page
- self._current_page = page
- self._page_specific_values_for_current_page = []
-
- def AddValue(self, value):
- super(PageMeasurementResults, self).AddValue(value)
- if not isinstance(value, failure.FailureValue):
- self._page_specific_values_for_current_page.append(value)
-
- def DidMeasurePage(self):
- assert self._current_page, 'Failed to call WillMeasurePage'
- self._current_page = None
- self._page_specific_values_for_current_page = None

Powered by Google App Engine
This is Rietveld 408576698