tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py - Issue 403093002: Merge all logic in PageMeasurementResults to PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

Issue 403093002: Merge all logic in PageMeasurementResults to PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/measurements/page_cycler_unittest.py ('K') | « tools/telemetry/telemetry/page/page_measurement.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py » ('j') | tools/telemetry/telemetry/results/page_test_results.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

index fe58e9a77dab0d0c7db4b2d88e58b2b536e32108..20c29954c28cf836c0eab637056f867574630ae0 100644

--- a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

@@ -43,15 +43,15 @@ class BlockPageMeasurementResultsTest(unittest.TestCase):

def testOutput(self):

results = NonPrintingBlockPageMeasurementResults(self._output)

- results.WillMeasurePage(self._page_set[0])

+ results.StartTest(self._page_set[0])

results.AddValue(

scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))

- results.DidMeasurePage()

+ results.StopTest(self._page_set[0])

- results.WillMeasurePage(self._page_set[1])

+ results.StartTest(self._page_set[1])

results.AddValue(

scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))

- results.DidMeasurePage()

+ results.StopTest(self._page_set[1])

results.PrintSummary()

expected = [