Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: sync/internal_api/public/base/invalidation.h

Issue 40303005: Add code for new invalidation local ack system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at fixing win Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/invalidation.h
diff --git a/sync/internal_api/public/base/invalidation.h b/sync/internal_api/public/base/invalidation.h
index 4e157e0597172126df0fcbdaae41f52799d7f0a9..472f552972a47529d2aad96aa23268b72d93a3bf 100644
--- a/sync/internal_api/public/base/invalidation.h
+++ b/sync/internal_api/public/base/invalidation.h
@@ -54,14 +54,19 @@ class SYNC_EXPORT Invalidation {
// TODO(rlarocque): Remove this method and use AckHandlers instead.
void set_ack_handle(const AckHandle& ack_handle);
+ // Functions from the alternative ack tracking framework.
+ // Currently unused.
void set_ack_handler(syncer::WeakHandle<AckHandler> ack_handler);
-
- // True if this class has a valid AckHandler.
bool SupportsAcknowledgement() const;
-
- // TODO(rlarocque): Re-enable these when we switch to AckHandlers.
- // void Acknowledge() const;
- // void Drop(DroppedInvalidationTracker* tracker) const;
+ void Acknowledge() const;
+
+ // Drops an invalidation.
+ //
+ // The drop record will be tracked by the specified
+ // DroppedInvalidationTracker. The caller should hang on to this tracker. It
+ // will need to use it when it recovers from this drop event. See the
+ // documentation of DroppedInvalidationTracker for more details.
+ void Drop(DroppedInvalidationTracker* tracker) const;
scoped_ptr<base::DictionaryValue> ToValue() const;
std::string ToString() const;
« no previous file with comments | « no previous file | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698