Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: sync/internal_api/public/base/invalidation.cc

Issue 40303005: Add code for new invalidation local ack system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at fixing win Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/public/base/invalidation.h ('k') | sync/notifier/ack_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/invalidation.cc
diff --git a/sync/internal_api/public/base/invalidation.cc b/sync/internal_api/public/base/invalidation.cc
index d60a324f9a3c9aacc250cb9e5ea5353d8e89e67a..1292a51bbe670198f22c896ad653bd760e19e1f8 100644
--- a/sync/internal_api/public/base/invalidation.cc
+++ b/sync/internal_api/public/base/invalidation.cc
@@ -10,6 +10,8 @@
#include "base/rand_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/values.h"
+#include "sync/notifier/ack_handler.h"
+#include "sync/notifier/dropped_invalidation_tracker.h"
#include "sync/notifier/invalidation_util.h"
namespace syncer {
@@ -121,19 +123,23 @@ bool Invalidation::SupportsAcknowledgement() const {
return ack_handler_.IsInitialized();
}
-// void Invalidation::Acknowledge() const {
-// if (SupportsAcknowledgement()) {
-// ack_handler_.Call(FROM_HERE,
-// &AckHandler::Acknowledge,
-// id_,
-// ack_handle_);
-// }
-// }
+void Invalidation::Acknowledge() const {
+ if (SupportsAcknowledgement()) {
+ ack_handler_.Call(FROM_HERE,
+ &AckHandler::Acknowledge,
+ id_,
+ ack_handle_);
+ }
+}
-// void Invalidation::Drop(DroppedInvalidationTracker* tracker) const {
-// DCHECK(tracker->object_id() == object_id());
-// tracker->Drop(ack_handler_, ack_handle_);
-// }
+void Invalidation::Drop(DroppedInvalidationTracker* tracker) const {
+ DCHECK(tracker->object_id() == object_id());
+ tracker->RecordDropEvent(ack_handler_, ack_handle_);
+ ack_handler_.Call(FROM_HERE,
+ &AckHandler::Drop,
+ id_,
+ ack_handle_);
+}
bool Invalidation::Equals(const Invalidation& other) const {
return id_ == other.id_
« no previous file with comments | « sync/internal_api/public/base/invalidation.h ('k') | sync/notifier/ack_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698