Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 402993002: Copy the PGO runtime library to the release directory (Closed)

Created:
6 years, 5 months ago by Sébastien Marchand
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy the PGO runtime library to the release directory BUG=395183 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284261

Patch Set 1 #

Total comments: 4

Patch Set 2 : Also copy the x64 bit dll. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M build/vs_toolchain.py View 1 3 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sébastien Marchand
PTAL.
6 years, 5 months ago (2014-07-18 18:41:28 UTC) #1
scottmg
https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcode115 build/vs_toolchain.py:115: if os.environ.get('GYP_MSVS_OVERRIDE_PATH'): hm, it'd be nicer to pass the ...
6 years, 5 months ago (2014-07-18 19:23:13 UTC) #2
Sébastien Marchand
Thanks, PTAnL. https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcode115 build/vs_toolchain.py:115: if os.environ.get('GYP_MSVS_OVERRIDE_PATH'): On 2014/07/18 19:23:13, scottmg wrote: ...
6 years, 5 months ago (2014-07-18 20:18:52 UTC) #3
scottmg
lgtm
6 years, 5 months ago (2014-07-18 21:05:48 UTC) #4
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 5 months ago (2014-07-18 21:06:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/402993002/20001
6 years, 5 months ago (2014-07-18 21:07:39 UTC) #6
commit-bot: I haz the power
Change committed as 284261
6 years, 5 months ago (2014-07-19 00:25:21 UTC) #7
Sébastien Marchand
6 years, 5 months ago (2014-07-20 13:52:43 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/401173002/ by sebmarchand@chromium.org.

The reason for reverting is: pgort120.dll isn't present in the express version
of VC..

Powered by Google App Engine
This is Rietveld 408576698