Copy the PGO runtime library to the release directory

Copy the PGO runtime library to the release directory

BUG=395183
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284261

[Sébastien Marchand, 2014-07-18 18:41:28]

PTAL.

[scottmg, 2014-07-18 19:23:13]

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:115: if os.environ.get('GYP_MSVS_OVERRIDE_PATH'):
hm, it'd be nicer to pass the source directory in, but random other projects are
poking into this module now so it's a bit of a mess to change :/

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:118: pgo_runtime_dll = 'pgort120.dll'
we need to copy the amd64\pgort120.dll to release_x64 too right?

[Sébastien Marchand, 2014-07-18 20:18:52]

Thanks, PTAnL.

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:115: if os.environ.get('GYP_MSVS_OVERRIDE_PATH'):
On 2014/07/18 19:23:13, scottmg wrote:
> hm, it'd be nicer to pass the source directory in, but random other projects
are
> poking into this module now so it's a bit of a mess to change :/

Yeah, I wanted to make sure that I didn't break anything here...

https://codereview.chromium.org/402993002/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:118: pgo_runtime_dll = 'pgort120.dll'
On 2014/07/18 19:23:13, scottmg wrote:
> we need to copy the amd64\pgort120.dll to release_x64 too right?

Yeah I think so, I haven't really worked on the x64 PGO build yet, but I'll add
it.

[scottmg, 2014-07-18 21:05:48]

lgtm

[Sébastien Marchand, 2014-07-18 21:06:04]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-07-18 21:07:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/402993002/20001

[commit-bot: I haz the power, 2014-07-19 00:25:21]

Change committed as 284261

[Sébastien Marchand, 2014-07-20 13:52:43]

A revert of this CL has been created in
https://codereview.chromium.org/401173002/ by sebmarchand@chromium.org.

The reason for reverting is: pgort120.dll isn't present in the express version
of VC..