Copy the PGO runtime library to the release directory

build/vs_toolchain.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 import pipes
 import shutil
 import subprocess
 import sys
@@ skipping 53 matching lines @@
 def CopyVsRuntimeDlls(output_dir, runtime_dirs):
   """Copies the VS runtime DLLs from the given |runtime_dirs| to the output
   directory so that even if not system-installed, built binaries are likely to
   be able to run.
 
   This needs to be run after gyp has been run so that the expected target
   output directories are already created.
   """
   assert sys.platform.startswith(('win32', 'cygwin'))
 
+  def copy_runtime_impl(target, source):
+    """Copy |source| to |target| if it doesn't already exist or if it need to be
+    updated.
+    """
+    if (os.path.isdir(os.path.dirname(target)) and
+        (not os.path.isfile(target) or
+          os.stat(target).st_mtime != os.stat(source).st_mtime)):
+      print 'Copying %s to %s...' % (source, target)
+      if os.path.exists(target):
+        os.unlink(target)
+      shutil.copy2(source, target)
+
   def copy_runtime(target_dir, source_dir, dll_pattern):
     """Copy both the msvcr and msvcp runtime DLLs, only if the target doesn't
     exist, but the target directory does exist."""
     for which in ('p', 'r'):
       dll = dll_pattern % which
       target = os.path.join(target_dir, dll)
       source = os.path.join(source_dir, dll)
-      # If gyp generated to that output dir, and the runtime isn't already
-      # there, then copy it over.
-      if (os.path.isdir(target_dir) and
-          (not os.path.isfile(target) or
-            os.stat(target).st_mtime != os.stat(source).st_mtime)):
-        print 'Copying %s to %s...' % (source, target)
-        if os.path.exists(target):
-          os.unlink(target)
-        shutil.copy2(source, target)
+      copy_runtime_impl(target, source)
 
   x86, x64 = runtime_dirs
   out_debug = os.path.join(output_dir, 'Debug')
   out_debug_nacl64 = os.path.join(output_dir, 'Debug', 'x64')
   out_release = os.path.join(output_dir, 'Release')
   out_release_nacl64 = os.path.join(output_dir, 'Release', 'x64')
   out_debug_x64 = os.path.join(output_dir, 'Debug_x64')
   out_release_x64 = os.path.join(output_dir, 'Release_x64')
 
   if os.path.exists(out_debug) and not os.path.exists(out_debug_nacl64):
     os.makedirs(out_debug_nacl64)
   if os.path.exists(out_release) and not os.path.exists(out_release_nacl64):
     os.makedirs(out_release_nacl64)
   copy_runtime(out_debug,          x86, 'msvc%s120d.dll')
   copy_runtime(out_release,        x86, 'msvc%s120.dll')
   copy_runtime(out_debug_x64,      x64, 'msvc%s120d.dll')
   copy_runtime(out_release_x64,    x64, 'msvc%s120.dll')
   copy_runtime(out_debug_nacl64,   x64, 'msvc%s120d.dll')
   copy_runtime(out_release_nacl64, x64, 'msvc%s120.dll')
 
+  # Copy the PGO runtime library to the release directory.
+  if os.environ.get('GYP_MSVS_OVERRIDE_PATH'):

[scottmg, 2014/07/18 19:23:13]

hm, it'd be nicer to pass the source directory in, but random other projects are
poking into this module now so it's a bit of a mess to change :/

[Sébastien Marchand, 2014/07/18 20:18:52]

Yeah, I wanted to make sure that I didn't break anything here...

+    pgo_runtime_dir = os.path.join(os.environ.get('GYP_MSVS_OVERRIDE_PATH'),
+                                   'VC', 'bin')
+    pgo_runtime_dll = 'pgort120.dll'

[scottmg, 2014/07/18 19:23:13]

we need to copy the amd64\pgort120.dll to release_x64 too right?

[Sébastien Marchand, 2014/07/18 20:18:52]

Yeah I think so, I haven't really worked on the x64 PGO build yet, but I'll add
it.

+    target = os.path.join(out_release, pgo_runtime_dll)
+    copy_runtime_impl(target, os.path.join(pgo_runtime_dir, pgo_runtime_dll))
+
 
 def _GetDesiredVsToolchainHashes():
   """Load a list of SHA1s corresponding to the toolchains that we want installed
   to build with."""
   sha1path = os.path.join(script_dir, 'toolchain_vs2013.hash')
   with open(sha1path, 'rb') as f:
     return f.read().strip().splitlines()
 
 
 def Update():
@@ skipping 44 matching lines @@
       # CopyVsRuntimeDlls via import, currently).
   }
   if len(sys.argv) < 2 or sys.argv[1] not in commands:
     print >>sys.stderr, 'Expected one of: %s' % ', '.join(commands)
     return 1
   return commands[sys.argv[1]]()
 
 
 if __name__ == '__main__':
   sys.exit(main())