Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 402913002: Don't force range of the RangeBoundary::Shl into the Smi. (Closed)

Created:
6 years, 5 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't force range of the RangeBoundary::Shl into the Smi. This caused overly conservative ranges to be computed for mint-shl expressions. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38402

Patch Set 1 #

Patch Set 2 : fix the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M runtime/vm/intermediate_language.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_test.cc View 1 3 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
PTAL
6 years, 5 months ago (2014-07-18 15:15:31 UTC) #1
Cutch
lgtm
6 years, 5 months ago (2014-07-18 18:06:46 UTC) #2
Vyacheslav Egorov (Google)
6 years, 5 months ago (2014-07-18 18:17:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698