Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 402913002: Don't force range of the RangeBoundary::Shl into the Smi. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix the tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index e23603fb493170adaf9683639b5a2d613187e894..34a83cfd186382175f82cfa703976aaf85df1d75 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -2732,7 +2732,7 @@ RangeBoundary RangeBoundary::Shl(const RangeBoundary& value_boundary,
((limit > 0) && (Utils::IsInt(limit, value)))) {
// Result stays in 64 bit range.
int64_t result = value << shift_count;
- return Smi::IsValid(result) ? RangeBoundary(result) : overflow;
+ return RangeBoundary(result);
}
return overflow;
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698