Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 402803003: Flush denormals to zero on arm and arm64. (Closed)

Created:
6 years, 5 months ago by Raymond Toy
Modified:
6 years, 5 months ago
CC:
blink-reviews, Raymond Toy
Project:
blink
Visibility:
Public.

Description

Flush denormals to zero on arm and arm64. We also slightly refactor the code to make it a little easier to read. The impact of denormals on arm appear to be much less pronounced than on x86, but flushing denormals will make arm and x86 results more similar. This was tested manually by creating a test to check the response of a lowpass filter to a very small impulse. All values after a certain point should be zero when denormals are flushed to zero. If denormals are not flushed, the non-zero output would last much longer. Verified on Linux, Windows, OSX, and Android that denormals are flushed. The test is not included; it seems not that important to ensure denormals are flushed. BUG=395254 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178620

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -25 lines) Patch
M Source/platform/audio/DenormalDisabler.h View 1 3 chunks +71 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Raymond Toy
PTAL
6 years, 5 months ago (2014-07-17 23:08:48 UTC) #1
Ken Russell (switch to Gerrit)
Needs more work. I also suggest you file a tracking bug in case this has ...
6 years, 5 months ago (2014-07-18 18:46:57 UTC) #2
Raymond Toy
https://codereview.chromium.org/402803003/diff/20001/Source/platform/audio/DenormalDisabler.h File Source/platform/audio/DenormalDisabler.h (right): https://codereview.chromium.org/402803003/diff/20001/Source/platform/audio/DenormalDisabler.h#newcode39 Source/platform/audio/DenormalDisabler.h:39: // Windows compiled using MSVC with SSE2 (_M_IX86_FP == ...
6 years, 5 months ago (2014-07-18 20:08:34 UTC) #3
Raymond Toy
PTAL.
6 years, 5 months ago (2014-07-21 20:56:14 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
6 years, 5 months ago (2014-07-21 22:11:17 UTC) #5
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 5 months ago (2014-07-22 03:19:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/402803003/40001
6 years, 5 months ago (2014-07-22 03:20:29 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 04:23:09 UTC) #8
Message was sent while issue was closed.
Change committed as 178620

Powered by Google App Engine
This is Rietveld 408576698