Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 402773002: [Ozone-DRI] Removing MockDriSurface implementation (Closed)

Created:
6 years, 5 months ago by dnicoara
Modified:
6 years, 5 months ago
Reviewers:
spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRI] Removing MockDriSurface implementation Consolidating all the mocked components in DriWrapper for easier testability of the DRI platform. This should also simplify unittesting since there won't be a need for interfaces and factories for the sake of testing. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283885

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -257 lines) Patch
M ui/ozone/platform/dri/dri.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_buffer.cc View 3 chunks +3 lines, -54 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 7 chunks +19 lines, -45 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_unittest.cc View 5 chunks +3 lines, -33 lines 1 comment Download
M ui/ozone/platform/dri/dri_wrapper.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 2 chunks +67 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller_unittest.cc View 9 chunks +10 lines, -11 lines 0 comments Download
D ui/ozone/platform/dri/test/mock_dri_surface.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/ozone/platform/dri/test/mock_dri_surface.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.h View 4 chunks +22 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.cc View 3 chunks +27 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/test/mock_surface_generator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_surface_generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dnicoara
PTAL I got tired of writing interfaces just to make testing feasible so I'm moving ...
6 years, 5 months ago (2014-07-17 19:50:08 UTC) #1
spang
lgtm
6 years, 5 months ago (2014-07-17 19:53:30 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 5 months ago (2014-07-17 21:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/402773002/1
6 years, 5 months ago (2014-07-17 21:26:21 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 21:29:03 UTC) #5
Message was sent while issue was closed.
Change committed as 283885

Powered by Google App Engine
This is Rietveld 408576698