Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: breakpad/BUILD.gn

Issue 402683003: Fix most GN clang errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/pulse/audio_manager_pulse.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 2c0ae49abbde09b0922b004f451e26cac916793f..53454ac5a478dbc7a43ee9748758d0e9c32a8cff 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -420,6 +420,8 @@ if (is_linux && current_toolchain == host_toolchain) {
"src/common/string_conversion.h",
]
+ configs -= [ "//build/config/compiler:chromium_code" ]
DaleCurtis 2014/07/17 18:29:49 These names aren't very helpful, something like st
brettw 2014/07/17 19:42:42 I just emulated gyp's "chromium_code: 1" since it'
+ configs += [ "//build/config/compiler:no_chromium_code" ]
direct_dependent_configs = [ ":breakpad_client_config" ]
# Android NDK toolchain doesn't support -mimplicit-it=always
@@ -551,7 +553,8 @@ if (is_linux && current_toolchain == host_toolchain) {
]
# This file has an unused variable warning.
- cflags = [ "-Wno-unused-variable" ]
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
deps = [ ":breakpad_client" ]
« no previous file with comments | « no previous file | media/audio/pulse/audio_manager_pulse.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698