Fix most GN clang errors.

breakpad/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("tools_config") {
   include_dirs = [ "src", "src/third_party" ]
   if (is_android) {
     defines = [ "__ANDROID__" ]
   }
   if (is_clang) {
@@ skipping 402 matching lines @@
       "src/common/linux/memory_mapped_file.h",
       "src/common/linux/safe_readlink.cc",
       "src/common/linux/safe_readlink.h",
       "src/common/memory.h",
       "src/common/simple_string_dictionary.cc",
       "src/common/simple_string_dictionary.h",
       "src/common/string_conversion.cc",
       "src/common/string_conversion.h",
     ]
 
+    configs -= [ "//build/config/compiler:chromium_code" ]

[DaleCurtis, 2014/07/17 18:29:49]

These names aren't very helpful, something like strict_warnings,
relaxed_warnings might be easier to follow.

[brettw, 2014/07/17 19:42:42]

I just emulated gyp's "chromium_code: 1" since it's what people are used to. You
might be right, but it's very difficult to change at this point.

+    configs += [ "//build/config/compiler:no_chromium_code" ]
     direct_dependent_configs = [ ":breakpad_client_config" ]
 
     # Android NDK toolchain doesn't support -mimplicit-it=always
     if (cpu_arch == "arm" && !is_android) {
       cflags = [ "-Wa,-mimplicit-it=always" ]
     }
     if (cpu_arch == "arm" && is_chromeos) {
       # Avoid running out of registers in
       # linux_syscall_support.h:sys_clone()'s inline assembly.
       cflags = [ "-marm" ]
@@ skipping 111 matching lines @@
     }
   }
 
 
   executable("generate_test_dump") {
     sources = [
       "linux/generate-test-dump.cc",
     ]
 
     # This file has an unused variable warning.
-    cflags = [ "-Wno-unused-variable" ]
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]
 
     deps = [ ":breakpad_client" ]
 
     include_dirs = [ "src" ]
 
     if (is_android) {
       libs = [ "log" ]
       include_dirs += [ "src/common/android/include" ]
     }
   }
@@ skipping 69 matching lines @@
 
     include_dirs = [
       "src",
       "src/client/mac/Framework",
       "src/common/mac",
     ]
   }
 
   # TODO(GYP) There is some XCode-only targets like ninja-breakpad.
 }