Issue 402683003: Fix most GN clang errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402683003: Fix most GN clang errors. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix most GN clang errors. Finally enabling Clang requires openssl and hunspell rolls. This should fix everything else. R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283894

Patch Set 2 : #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -1 line)			Patch
M	breakpad/BUILD.gn	View	2 chunks	+4 lines, -1 line	2 comments	Download
M	media/audio/pulse/audio_manager_pulse.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/opus/BUILD.gn	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

lgtm https://codereview.chromium.org/402683003/diff/20001/breakpad/BUILD.gn File breakpad/BUILD.gn (right): https://codereview.chromium.org/402683003/diff/20001/breakpad/BUILD.gn#newcode423 breakpad/BUILD.gn:423: configs -= [ "//build/config/compiler:chromium_code" ] These names aren't ...

6 years, 5 months ago (2014-07-17 18:29:50 UTC) #2

brettw

https://codereview.chromium.org/402683003/diff/20001/breakpad/BUILD.gn File breakpad/BUILD.gn (right): https://codereview.chromium.org/402683003/diff/20001/breakpad/BUILD.gn#newcode423 breakpad/BUILD.gn:423: configs -= [ "//build/config/compiler:chromium_code" ] On 2014/07/17 18:29:49, DaleCurtis ...

6 years, 5 months ago (2014-07-17 19:42:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r283894.

Expand Messages | Collapse Messages

Issue 402683003: Fix most GN clang errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages