Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 402663002: Remove results.Add and value_backcompat. (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove results.Add and value_backcompat. BUG=346958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M tools/telemetry/telemetry/results/page_measurement_results.py View 2 chunks +0 lines, -10 lines 0 comments Download
D tools/telemetry/telemetry/value/value_backcompat.py View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-17 16:53:51 UTC) #1
tonyg
lgtm woot :)
6 years, 5 months ago (2014-07-17 17:22:52 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-17 17:32:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/402663002/1
6 years, 5 months ago (2014-07-17 17:35:20 UTC) #4
chrishenry
lgtm, woohooo!!
6 years, 5 months ago (2014-07-17 17:54:50 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 18:42:45 UTC) #6
Message was sent while issue was closed.
Change committed as 283826

Powered by Google App Engine
This is Rietveld 408576698