Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results.py

Issue 402663002: Remove results.Add and value_backcompat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/value_backcompat.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_measurement_results.py
diff --git a/tools/telemetry/telemetry/results/page_measurement_results.py b/tools/telemetry/telemetry/results/page_measurement_results.py
index bd650dd80237051684fbf9eb32eaf1ea27a546ce..abaf784ba3ac73a10f2697e65e21913477485507 100644
--- a/tools/telemetry/telemetry/results/page_measurement_results.py
+++ b/tools/telemetry/telemetry/results/page_measurement_results.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
from telemetry.results import page_test_results
-from telemetry.value import value_backcompat
class PageMeasurementResults(page_test_results.PageTestResults):
def __init__(self, output_stream=None, trace_tag=''):
@@ -27,15 +26,6 @@ class PageMeasurementResults(page_test_results.PageTestResults):
self._current_page = page
self._page_specific_values_for_current_page = []
- # TODO(nednguyen): Ned has a patch to kill this.
- def Add(self, trace_name, units, value, chart_name=None, data_type='default'):
- assert self._current_page
- # TODO(isherman): Remove this as well.
- value = value_backcompat.ConvertOldCallingConventionToValue(
- self._current_page,
- trace_name, units, value, chart_name, data_type)
- self.AddValue(value)
-
def AddValue(self, value):
super(PageMeasurementResults, self).AddValue(value)
self._page_specific_values_for_current_page.append(value)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/value_backcompat.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698