Issue 40246: Generate data packs for all languages and allow us to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40246: Generate data packs for all languages and allow us to load (Closed)

Created:
11 years, 9 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Generate data packs for all languages and allow us to load any lang (currently using --lang=ar or whatever). Also remove app/resources/SConscript since it's filled with windows specific code. BUG=8125

Patch Set 1 #

Patch Set 2 : spacing #

Patch Set 3 : comment #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -264 lines)			Patch
M	chrome/SConscript	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/app/chrome_strings.scons	View	1 2	1 chunk	+18 lines, -9 lines	0 comments	Download
M	chrome/app/chromium_strings.grd	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 2	2 chunks	+51 lines, -14 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/app/resources/SConscript	View		1 chunk	+0 lines, -230 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
M	chrome/common/resource_bundle_linux.cc	View		1 chunk	+8 lines, -5 lines	1 comment	Download
M	webkit/glue/webkit_strings.grd	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LG with one question http://codereview.chromium.org/40246/diff/1002/36 File chrome/common/resource_bundle_linux.cc (right): http://codereview.chromium.org/40246/diff/1002/36#newcode48 Line 48: return; Shouldn't we die ...

11 years, 9 months ago (2009-03-06 20:39:52 UTC) #2

tony

11 years, 9 months ago (2009-03-06 21:33:46 UTC) #3

On 2009/03/06 20:39:52, Evan Martin wrote:
> LG with one question
> 
> http://codereview.chromium.org/40246/diff/1002/36
> File chrome/common/resource_bundle_linux.cc (right):
> 
> http://codereview.chromium.org/40246/diff/1002/36#newcode48
> Line 48: return;
> Shouldn't we die horribly here?

We currently try to keep running and return "" for every localized string.  I
don't have a strong opinion whether we should CHECK() or not.

Expand Messages | Collapse Messages