Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 402433002: [Telemetry] Partial fix for Telemetry unittests on Android after r283119 (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix for Telemetry unittests on Android after r283119 BUG=337829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283639

Patch Set 1 #

Patch Set 2 : Skip test which closes a tab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/tab_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/tab_test_case.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
Hey Dave, looks like the patch to reduce browser launches breaks a lot of tests ...
6 years, 5 months ago (2014-07-16 19:22:29 UTC) #1
dtu
On 2014/07/16 19:22:29, tonyg wrote: > Hey Dave, looks like the patch to reduce browser ...
6 years, 5 months ago (2014-07-16 20:47:44 UTC) #2
dtu
On 2014/07/16 20:47:44, dtu wrote: > On 2014/07/16 19:22:29, tonyg wrote: > > Hey Dave, ...
6 years, 5 months ago (2014-07-16 20:48:42 UTC) #3
tonyg
> I think it might be this particular test > tab_unittest.TabTest.testGetRendererThreadFromTabId needs the "has tabs" ...
6 years, 5 months ago (2014-07-16 21:12:44 UTC) #4
dtu
lgtm
6 years, 5 months ago (2014-07-16 21:18:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/402433002/20001
6 years, 5 months ago (2014-07-16 21:22:12 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:20:55 UTC) #7
Message was sent while issue was closed.
Change committed as 283639

Powered by Google App Engine
This is Rietveld 408576698