Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: tools/telemetry/telemetry/unittest/tab_test_case.py

Issue 402433002: [Telemetry] Partial fix for Telemetry unittests on Android after r283119 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Skip test which closes a tab Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest/tab_test_case.py
diff --git a/tools/telemetry/telemetry/unittest/tab_test_case.py b/tools/telemetry/telemetry/unittest/tab_test_case.py
index f68a1bcbf3f839b2a97c1119f289dbff919b0ad9..431817d2a918725896aadce898053c49af7c7609 100644
--- a/tools/telemetry/telemetry/unittest/tab_test_case.py
+++ b/tools/telemetry/telemetry/unittest/tab_test_case.py
@@ -40,9 +40,12 @@ class TabTestCase(unittest.TestCase):
raise
def setUp(self):
- self._tab = self._browser.tabs.New()
- while len(self._browser.tabs) > 1:
- self._browser.tabs[0].Close()
+ if self._browser.supports_tab_control:
+ self._tab = self._browser.tabs.New()
+ while len(self._browser.tabs) > 1:
+ self._browser.tabs[0].Close()
+ else:
+ self._tab = self._browser.tabs[0]
self._tab.Navigate('about:blank')
self._tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698