Added code to fix visibility of select all option in context menu.

Source/web/ContextMenuClientImpl.cpp

Index: Source/web/ContextMenuClientImpl.cpp
diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp
index 517305b7570e797255ab3ac8d6ee9ef5271aafa6..69bcc52ba957271fc25a05ab1957153542ec38af 100644
--- a/Source/web/ContextMenuClientImpl.cpp
+++ b/Source/web/ContextMenuClientImpl.cpp
@@ -219,8 +219,14 @@ void ContextMenuClientImpl::showContextMenu(const blink::ContextMenu* defaultMen
         data.editFlags |= WebContextMenuData::CanPaste;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canDelete())
         data.editFlags |= WebContextMenuData::CanDelete;
-    // We can always select all...
-    data.editFlags |= WebContextMenuData::CanSelectAll;
+    Node* node = r.innerNonSharedNode();
+    if (node->isElementNode() && (static_cast<Element*>(node))->isFormControlElement()) {

[darin (slow to review), 2014/07/25 16:43:36]

why do you bother calling isFormControlElement? why not just call
isTextFormControl?

it looks like you can write this code like so:

  if (isHTMLTextFormControlElement(r.innerNonSharedNode())) {
      if
(!toHTMLTextFormControlElement(r.innerNonSharedNode())->value().isEmpty())
          data.editFlags |= WebContextMenuData::CanSelectAll;
  }

that seems simpler, right?

[ankit, 2014/07/28 04:08:06]

Acknowledged.
I have made changes as suggested and uploaded a new patch. 
PTAL

+        Element* element = toHTMLFormControlElement(node);
+        if (element->isTextFormControl()) {
+            if (!(static_cast<HTMLTextFormControlElement*>(element))->value().isEmpty())
+                data.editFlags |= WebContextMenuData::CanSelectAll;
+        }
+    }
     data.editFlags |= WebContextMenuData::CanTranslate;
 
     // Links, Images, Media tags, and Image/Media-Links take preference over