Added code to fix visibility of select all option in context menu.

Source/web/ContextMenuClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 201 matching lines @@
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canRedo())
         data.editFlags |= WebContextMenuData::CanRedo;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCut())
         data.editFlags |= WebContextMenuData::CanCut;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCopy())
         data.editFlags |= WebContextMenuData::CanCopy;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canPaste())
         data.editFlags |= WebContextMenuData::CanPaste;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canDelete())
         data.editFlags |= WebContextMenuData::CanDelete;
-    // We can always select all...
-    data.editFlags |= WebContextMenuData::CanSelectAll;
+    Node* node = r.innerNonSharedNode();
+    if (node->isElementNode() && (static_cast<Element*>(node))->isFormControlElement()) {

[darin (slow to review), 2014/07/25 16:43:36]

why do you bother calling isFormControlElement? why not just call
isTextFormControl?

it looks like you can write this code like so:

  if (isHTMLTextFormControlElement(r.innerNonSharedNode())) {
      if
(!toHTMLTextFormControlElement(r.innerNonSharedNode())->value().isEmpty())
          data.editFlags |= WebContextMenuData::CanSelectAll;
  }

that seems simpler, right?

[ankit, 2014/07/28 04:08:06]

Acknowledged.
I have made changes as suggested and uploaded a new patch. 
PTAL

+        Element* element = toHTMLFormControlElement(node);
+        if (element->isTextFormControl()) {
+            if (!(static_cast<HTMLTextFormControlElement*>(element))->value().isEmpty())
+                data.editFlags |= WebContextMenuData::CanSelectAll;
+        }
+    }
     data.editFlags |= WebContextMenuData::CanTranslate;
 
     // Links, Images, Media tags, and Image/Media-Links take preference over
     // all else.
     data.linkURL = r.absoluteLinkURL();
 
     if (isHTMLCanvasElement(r.innerNonSharedNode())) {
         data.mediaType = WebContextMenuData::MediaTypeCanvas;
         data.hasImageContents = true;
     } else if (!r.absoluteImageURL().isEmpty()) {
@@ skipping 203 matching lines @@
         outputItems[i] = subItems[i];
     subMenuItems.swap(outputItems);
 }
 
 void ContextMenuClientImpl::populateCustomMenuItems(const blink::ContextMenu* defaultMenu, WebContextMenuData* data)
 {
     populateSubMenuItems(defaultMenu->items(), data->customItems);
 }
 
 } // namespace blink