Issue 402283002: Modify TraceEventTestFixture.TraceBufferVectorReportFull to assert the overflowed_at_ts is between …

Issue 402283002: Modify TraceEventTestFixture.TraceBufferVectorReportFull to assert the overflowed_at_ts is between … (Closed)

Created:
6 years, 5 months ago by nednguyen

Modified:
6 years, 5 months ago

Reviewers:
dsinclair, cpu_(ooo_6.6-7.5), Xianzhu, bruening

CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Modify TraceEventTestFixture.TraceBufferVectorReportFull to assert the overflowed_at_ts is between the timestamp of last event and current trace_log's time. BUG=395739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284702

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	base/debug/trace_event_unittest.cc	View		1 chunk	+5 lines, -4 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/402283002/1

6 years, 5 months ago (2014-07-22 15:05:38 UTC) #3

Derek Bruening

Could you also remove the test exclusions for TraceEventTestFixture.TraceBufferVectorReportFull which the memory sheriff added in ...

6 years, 5 months ago (2014-07-22 16:37:10 UTC) #5

cpu_(ooo_6.6-7.5)

https://codereview.chromium.org/402283002/diff/1/base/debug/trace_event_unittest.cc File base/debug/trace_event_unittest.cc (right): https://codereview.chromium.org/402283002/diff/1/base/debug/trace_event_unittest.cc#newcode2463 base/debug/trace_event_unittest.cc:2463: trace_log->OffsetNow().ToInternalValue()); I think this should be EXPECT_LE See the ...

6 years, 5 months ago (2014-07-24 22:58:18 UTC) #6

nednguyen

6 years, 5 months ago (2014-07-24 23:09:01 UTC) #7

Message was sent while issue was closed.

On 2014/07/24 22:58:18, cpu wrote:
>
https://codereview.chromium.org/402283002/diff/1/base/debug/trace_event_unitt...
> File base/debug/trace_event_unittest.cc (right):
> 
>
https://codereview.chromium.org/402283002/diff/1/base/debug/trace_event_unitt...
> base/debug/trace_event_unittest.cc:2463:
> trace_log->OffsetNow().ToInternalValue());
> I think this should be EXPECT_LE
> 
> See the failure here, if the systemwide timer frequency is a bit slower:
> 
> https://codereview.chromium.org/415783004/

Thanks cpu, I fixed it in: https://codereview.chromium.org/412033003/

Expand Messages | Collapse Messages