Modify TraceEventTestFixture.TraceBufferVectorReportFull to assert the overflowed_at_ts is between …

base/debug/trace_event_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_unittest.h"
 
 #include <math.h>
 #include <cstdlib>
 
 #include "base/bind.h"
@@ skipping 2432 matching lines @@
   EXPECT_TRUE(trace_full_metadata);
   EXPECT_TRUE(trace_full_metadata->GetString("ph", &phase));
   EXPECT_EQ("M", phase);
   EXPECT_TRUE(trace_full_metadata->GetDouble(
       "args.overflowed_at_ts", &buffer_limit_reached_timestamp));
   EXPECT_DOUBLE_EQ(
       static_cast<double>(
           trace_log->buffer_limit_reached_timestamp_.ToInternalValue()),
       buffer_limit_reached_timestamp);
 
-  // Test that buffer_limit_reached_timestamp's value is near to the timestamp
-  // of the last trace event.
+  // Test that buffer_limit_reached_timestamp's value is between the timestamp
+  // of the last trace event and current time.
   DropTracedMetadataRecords();
   const DictionaryValue* last_trace_event = NULL;
   double last_trace_event_timestamp = 0;
   EXPECT_TRUE(trace_parsed_.GetDictionary(trace_parsed_.GetSize() - 1,
                                           &last_trace_event));
   EXPECT_TRUE(last_trace_event->GetDouble("ts", &last_trace_event_timestamp));
-  // The difference between the two timestamps should be less than 50ms.
-  EXPECT_NEAR(last_trace_event_timestamp, buffer_limit_reached_timestamp, 50);
+  EXPECT_LT(last_trace_event_timestamp, buffer_limit_reached_timestamp);
+  EXPECT_LT(buffer_limit_reached_timestamp,
+            trace_log->OffsetNow().ToInternalValue());

[cpu_(ooo_6.6-7.5), 2014/07/24 22:58:18]

I think this should be EXPECT_LE

See the failure here, if the systemwide timer frequency is a bit slower:

https://codereview.chromium.org/415783004/

 }
 
 TEST_F(TraceEventTestFixture, TraceBufferRingBufferGetReturnChunk) {
   TraceLog::GetInstance()->SetEnabled(CategoryFilter("*"),
                                       base::debug::TraceLog::RECORDING_MODE,
                                       TraceLog::RECORD_CONTINUOUSLY);
   TraceBuffer* buffer = TraceLog::GetInstance()->trace_buffer();
   size_t capacity = buffer->Capacity();
   size_t num_chunks = capacity / TraceBufferChunk::kTraceBufferChunkSize;
   uint32 last_seq = 0;
@@ skipping 447 matching lines @@
 }
 
 TEST_F(TraceEventTestFixture, SyntheticDelayConfigurationToString) {
   const char config[] = "DELAY(test.Delay;16;oneshot)";
   CategoryFilter filter(config);
   EXPECT_EQ(config, filter.ToString());
 }
 
 }  // namespace debug
 }  // namespace base