Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/chromeos/login/screens/user_image_screen.cc

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/user_image_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/user_image_screen.cc b/chrome/browser/chromeos/login/screens/user_image_screen.cc
index 502024b17b04dc2dbbf8144ac923408e2a6c5608..cc67f0fe9098f8def3df13fcf90c3841b7db3566 100644
--- a/chrome/browser/chromeos/login/screens/user_image_screen.cc
+++ b/chrome/browser/chromeos/login/screens/user_image_screen.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/chromeos/camera_presence_notifier.h"
#include "chrome/browser/chromeos/login/login_utils.h"
#include "chrome/browser/chromeos/login/screens/screen_observer.h"
-#include "chrome/browser/chromeos/login/users/avatar/default_user_images.h"
#include "chrome/browser/chromeos/login/users/avatar/user_image_manager.h"
#include "chrome/browser/chromeos/login/users/user_manager.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
@@ -32,6 +31,7 @@
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_namespace.h"
#include "components/policy/core/common/policy_service.h"
+#include "components/user_manager/user_image/default_user_images.h"
#include "components/user_manager/user_image/user_image.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -167,7 +167,7 @@ void UserImageScreen::OnImageSelected(const std::string& image_type,
return;
int user_image_index = User::kInvalidImageIndex;
if (image_type == "default" &&
- IsDefaultImageUrl(image_url, &user_image_index)) {
+ user_manager::IsDefaultImageUrl(image_url, &user_image_index)) {
selected_image_ = user_image_index;
} else if (image_type == "camera") {
selected_image_ = User::kExternalImageIndex;
@@ -190,22 +190,23 @@ void UserImageScreen::OnImageAccepted() {
}
image_manager->SaveUserImage(
user_manager::UserImage::CreateAndEncode(user_photo_));
- uma_index = kHistogramImageFromCamera;
+ uma_index = user_manager::kHistogramImageFromCamera;
break;
case User::kProfileImageIndex:
image_manager->SaveUserImageFromProfileImage();
- uma_index = kHistogramImageFromProfile;
+ uma_index = user_manager::kHistogramImageFromProfile;
break;
default:
- DCHECK(selected_image_ >= 0 && selected_image_ < kDefaultImagesCount);
+ DCHECK(selected_image_ >= 0 &&
+ selected_image_ < user_manager::kDefaultImagesCount);
image_manager->SaveUserDefaultImageIndex(selected_image_);
- uma_index = GetDefaultImageHistogramValue(selected_image_);
+ uma_index = user_manager::GetDefaultImageHistogramValue(selected_image_);
break;
}
if (user_has_selected_image_) {
UMA_HISTOGRAM_ENUMERATION("UserImage.FirstTimeChoice",
uma_index,
- kHistogramImagesCount);
+ user_manager::kHistogramImagesCount);
}
ExitScreen();
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698