Issue 401943002: Fixups to keystore_openssl.cc after BoringSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401943002: Fixups to keystore_openssl.cc after BoringSSL. (Closed)

Created:
6 years, 5 months ago by davidben

Modified:
6 years, 5 months ago

Reviewers:
agl

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixups to keystore_openssl.cc after BoringSSL. Some 'return 1's should be 'return 0's. A couple mixed up error codes. Also be consistent about 'ec_key' vs 'eckey' vs 'key'. BUG=none

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	net/android/keystore_openssl.cc	View		10 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidben

I probably should have caught these in the initial review. As before, probably to be ...

6 years, 5 months ago (2014-07-18 21:34:28 UTC) #1

davidben

6 years, 5 months ago (2014-07-22 20:37:20 UTC) #3

On 2014/07/19 00:06:50, agl wrote:
> lgtm

Got landed as part of BoringSSL cutover.

Expand Messages | Collapse Messages